[OpenWrt-Devel] [PATCH v2 05/11] ltq-vdsl-app: make the dsl_control application stop cleanly

[Alexander Couzens]

On Sun, 28 Feb 2016 19:44:28 +0100
Hauke Mehrtens <hauke at hauke-m.de> wrote:

> I am not calling dsl_cmd because I want to ignore the lock, quit
> should also be send when someone else is accessing it. I saw that some
> other call was stuck here and all following calls were stuck in the
> dsl_cmd lock.
> 
> Signed-off-by: Hauke Mehrtens <hauke at hauke-m.de>
> ---
>  package/network/config/ltq-vdsl-app/files/dsl_control | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/network/config/ltq-vdsl-app/files/dsl_control
> b/package/network/config/ltq-vdsl-app/files/dsl_control index
> d7ba622..9c8dbad 100644 ---
> a/package/network/config/ltq-vdsl-app/files/dsl_control +++
> b/package/network/config/ltq-vdsl-app/files/dsl_control @@ -219,6
> +219,7 @@ start_service() { }
>  
>  stop_service() {

why not adding a comment about the lock?

> +	echo quit > /tmp/pipe/dsl_cpe0_cmd 
>  	DSL_NOTIFICATION_TYPE="DSL_INTERFACE_STATUS" \
>  	DSL_INTERFACE_STATUS="DOWN" \
>  		/sbin/dsl_notify.sh



-- 
Alexander Couzens

mail: lynxis at fe80.eu
jabber: lynxis at fe80.eu
mobile: +4915123277221
gpg: 390D CF78 8BF9 AA50 4F8F  F1E2 C29E 9DA6 A0DF 8604
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20160229/c305ae42/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel