[OpenWrt-Devel] [RFC] ramips: fix bad patch awake rt305x USB controller

John Crispin john at phrozen.org
Mon Apr 25 09:11:10 EDT 2016


Hi,

i dont see why this is needed.the patch in the tree does not look broken
and seems to compile fine.

	John

On 23/04/2016 05:55, Сергей Василюгин wrote:
> Sorry, fix bad patch (ticket #22248)
> 
> Signed-Off-By: Serge Vasilugin <vasilugin at yandex.ru>
> 
> diff --git a/target/linux/ramips/patches-4.4/0069-awake-rt305x-dwc2-controller.patch b/target/linux/ramips/patches-4.4/0069-awake-rt305x-dwc2-controller.patch
> index 9608f6f..2ba462d 100644
> --- a/target/linux/ramips/patches-4.4/0069-awake-rt305x-dwc2-controller.patch
> +++ b/target/linux/ramips/patches-4.4/0069-awake-rt305x-dwc2-controller.patch
> @@ -1,15 +1,15 @@
>  --- a/drivers/usb/dwc2/platform.c
>  +++ b/drivers/usb/dwc2/platform.c
>  @@ -375,6 +375,12 @@ static int dwc2_driver_probe(struct plat
> - dev_dbg(&dev->dev, "mapped PA %08lx to VA %p\n",
> - (unsigned long)res->start, hsotg->regs);
> + 	dev_dbg(&dev->dev, "mapped PA %08lx to VA %p\n",
> + 		(unsigned long)res->start, hsotg->regs);
>   
> -+ /* Enable USB port before any regs access */
> -+ if(dwc2_readl(hsotg->regs + PCGCTL) & 0x0f) {
> -+ dwc2_writel(0x00, hsotg->regs + PCGCTL);
> -+ /* TODO: mdelay(25) here? vendor driver don't use it */
> -+ }
> ++	/* Enable USB port before any regs access */
> ++	if(dwc2_readl(hsotg->regs + PCGCTL) & 0x0f) {
> ++		dwc2_writel(0x00, hsotg->regs + PCGCTL);
> ++		/* TODO: mdelay(25) here? vendor driver don't use it */
> ++	}
>  +
> - hsotg->dr_mode = usb_get_dr_mode(&dev->dev);
> - if (IS_ENABLED(CONFIG_USB_DWC2_HOST) &&
> - hsotg->dr_mode != USB_DR_MODE_HOST) {
> + 	hsotg->dr_mode = usb_get_dr_mode(&dev->dev);
> + 	if (IS_ENABLED(CONFIG_USB_DWC2_HOST) &&
> + 			hsotg->dr_mode != USB_DR_MODE_HOST) {
> 
> ---
> serge
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
> 
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list