[OpenWrt-Devel] [PATCH] pinctrl/lantiq: split xway_mfp into dedicated tables

Martin Schiller mschiller at tdt.de
Tue Nov 17 02:16:56 EST 2015


On 11/16/2015 at 9:28 PM, Hauke Mehrtens wrote:
> Hi Martin,
> The get_maintainer.pl helps to find the correct mailing list, it
> searches the MAINTAINERS file.
> ./scripts/get_maintainer.pl -f drivers/pinctrl/pinctrl-xway.c
> Linus Walleij <linus.walleij at linaro.org> (maintainer:PIN CONTROL
> linux-gpio at vger.kernel.org (open list:PIN CONTROL SUBSYSTEM)
> linux-kernel at vger.kernel.org (open list)

Thanks, John already told me to use the get_maintainer.pl script.

> You should probably not send it to linux-kernel at vger.kernel.org.
> In addition you should send it to blogic at openwrt.org as he is the main
> author.
> I assume John is ok if you also send his patch
> 0012-pinctrl-lantiq-fix-up-pinmux.patch upstream. When you use git
> send-mail it should preserve the author name.

I think we have to review this patch again, because it changes more
than that what is stated in the comment.
Maybe we have to split it up in several parts to get it upstream?

> Can you please also add me in cc as well, thanks.


> You changed the compatible string, this is considered ABI in the Linux
> kernel and should stay compatible with older versions, so that you can
> use an older DTS file with a recent kernel. Could you only add the new
> names in of_device_id xway_match and not remove the old ones, so that
> both will work.

So I will leave the old stuff (pinctrl-xway and pinctrl-xr9), mark them
as deprecated and add the new ones (pinctrl-danube, pinctrl-xrx100 and
pinctrl-xrx200). Of course, the Documentation will also be updated.

> I send some patches to add basic support for the xrx300 upstream and it
> is included in Linux 4.4, it boots. ;-)

Ah, nice work! I want to use the USIF UART of the xRX200, so it was also
on my todo list to adapt the Lantiq UGW PMU Patches to the free world. ;-)

But maybe you overlooked some little details:

The PMU_ASC0 should be removed from the "generic xway clocks" section.
Instead, the PMU_ASC1 should go there because it is available on every
XWAY SoC (even on the Amazon-SE).

Also, the quotation marks should be removed from the second parameter of
the clkdev_add_pmu("1da0000.usif", "NULL", 1, 0, PMU_USIF) calls.

Looking forward to meet again on the next Summit,

openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list