[OpenWrt-Devel] [PATCH] x86: add a subtarget for PCEngines APU
nbd at openwrt.org
Sun Nov 8 07:26:39 EST 2015
On 2015-11-08 13:07, Russell Senior wrote:
>>>>>> "Felix" == Felix Fietkau <nbd at openwrt.org> writes:
> Felix> On 2015-11-08 07:24, Russell Senior wrote:
>>> Reworked from patch by Ben Pfountz <netprince at vt.edu> Builds and
>>> Signed-off-by: Russell Senior <russell at personaltelco.net>
> Felix> Why do we need a subtarget for APU instead of just running the
> Felix> generic one on it?
> It conveniently selects/deselects a bunch of .config options (e.g. sets
> an appropriate BAUDRATE, selects USB options). I haven't studied all the
> differences closely.
I don't see where in the patch it sets the baudrate. Either way, I'm not
a big fan of having too many subtargets, and I don't think APU is
special enough to get its own.
Having said that, Imre Kaloz (who maintains the x86_64 subtarget) does
not really like having extra config options for embedded devices enabled
in the x86_64 subtarget.
A while back, Felix Kaechele (Cc'd) wanted to add support for a thin
client device to that subtarget, and Imre rejected the change.
I think a good solution would be to add a new subtarget for 'embedded'
64-bit devices, and using that for the APU device. This subtarget could
be useful for Felix' thin clients as well.
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
More information about the openwrt-devel