[OpenWrt-Devel] [PATCH] scripts: fix ubinize-image on OS X

[John Crispin]

Hi Álvaro,

On 05/03/2015 16:31, Álvaro Fernández Rojas wrote:
> Signed-off-by: Álvaro Fernández Rojas <noltari at gmail.com> --- 
> scripts/ubinize-image.sh | 3 +-- 1 file changed, 1 insertion(+), 2
> deletions(-)
> 
> diff --git a/scripts/ubinize-image.sh b/scripts/ubinize-image.sh 
> index 6762c22..4fbbbfa 100755 --- a/scripts/ubinize-image.sh +++
> b/scripts/ubinize-image.sh @@ -98,7 +98,7 @@ if [ ! -x "$ubinize"
> ]; then exit 1 fi
> 
> -ubinizecfg="$( mktemp )" +ubinizecfg="$( mktemp 2> /dev/null ||
> mktemp -t 'ubitmp' )"

i think the next person wont know the purpose of this patch. how about

ubinizecfg="$( mktemp 2> /dev/null )"
[ -z "$ubinizecfg" ] && {
	# try OSX siganture
	ubinizecfg="$( mktemp -t 'ubitmp' )"
}

little bit of extra code but understandable in 1-2 years time

	John
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel