[OpenWrt-Devel] b53 switch platform_data vs. device tree

Daniel Golle daniel at makrotopia.org
Tue Feb 17 15:56:28 EST 2015


On Tue, Feb 17, 2015 at 02:29:37PM +0100, Jonas Gorski wrote:
> > I'm not interested in brcm63xx and don't have any such hardware flying
> > around. I can implement minimal OF support and make sure at least
> > dev->of_node is set. This shoudn't do any harm and would allow a
> > graceful migration path.
> There is no reason for not supporting both, so feel free to submit patches.

After getting a bit into it, I believe there are some things which need
to be done in preparation of OF-based registration:
As MDIO-connected b53 is currently registered by probing the mdio bus,
it's hard to tell which hardware actually comes with that variant.
So thus there are currently 2 ways of registering b53:
 - (uninformed) probing of the MDIO bus
 - platform_data (or device-tree) for MMIO, SPI and SRAB

I reckon we need something similar to the changes Gabor made in r36050
to the AR8216/AR8327 driver to remove the nasty work-around I made in
r44215 and allow registering MDIO-connected b53 from probe() instead
of config_init() if device-tree hints that it's supposed to be there.

I'll have some time to work on this next week (currently I'm too busy
with other things), I'd be happy for any useful hints till then ;)


openwrt-devel mailing list
openwrt-devel at lists.openwrt.org

More information about the openwrt-devel mailing list