[OpenWrt-Devel] [PATCH] [rpcd][v2] file: add md5sum support

[John Crispin]

[...]

>>> +	if (!S_ISREG(s.st_mode))
>>> +		return UBUS_STATUS_NOT_SUPPORTED;
>>
>> should this not be -> UBUS_STATUS_INVALID_ARGUMENT
> 
> I think "not supported" in response to "md5sum of a non-regular file"
> (like a chardev or directory) makes sense here - imho.
> 

your codebase, so your call :-) i'll merge it as is then if that is fine
with you
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel