[OpenWrt-Devel] [PATCH 1/4] [WEIO] Adding WeIO profile

[John Crispin]

Hi,

please resend with the patches inline, it is not possible to comment
when they are attached.

also, my first impression is that the patches are really messy and the
commit text only partially matches what is inside the patches.

1/4 seems to have a pile of unrelated white space fixes.

1/4 adds a file only for 2/4 and 3/4 to "fix it"

4/4 adds code with incorrect indenting

this is all not bad and we can fix it, however for that to be possible
you need to send the patches inline.

using git send-email is the best way to do so.

last but not least, this is a carambola2 carrier board, with a lpc uC on
it ? is this the uC that had a usb device stack in firmware ?

	John

On 30/06/2014 13:59, Drasko DRASKOVIC wrote:
> This patch adds WeIO board profile.
> 
> WeIO is the new AR9331 MIPS based board for Internet of Things.
> Project web-site is: http://we-io.net/
> 
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
> 
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel