[OpenWrt-Devel] [PATCH] [mpc83xx] add menuconfig-option for rb333 and rb600

Imre Kaloz kaloz at openwrt.org
Fri Jul 25 06:25:01 EDT 2014


Hi,

On Fri, 25 Jul 2014 11:34:49 +0200, Claudio Thomas <ct at xmodus-systems.de> wrote:

> Hi, as reaction of the following email:
>On 15.07.2014 15:05, Claudio Thomas wrote:
>> Subject: [OpenWrt-Devel] When to use Target Profile or Subtarget
>>
>> Hi,
>> I'm adapting the "Freescale MPC83xx" platform, so that multiple devices
>> can be selected.
>> Actually the following boards are in use, but hard-coded over files or
>> file-patches and not selectable be "menuconfig"
>> - RouterBOARD 333
>> - RouterBOARD 600
>> This makes it unnecessary difficult to add new devices...
> ...I've wrote the in the subject mentioned patch (2014-07-21 15:48:12).
> Is there a reason why the patch is not committed yet?
> Should I change anything, like make only one profile for rb333+rb600 or
> is the coding style not as whiched?
>
> I would be glad to adapt the patch to be conform to the needs of OpenWrt.
> My goal is, that I would like to add the following boards:
> http://www.xmodus-systems.de/en/terminals/routers.html
> But to add them, it is necessary that the compilation of the kernelnames
> "dtbImage.rb600 dtbImage.rb333" needs to be conditional. Actually they
> are unconditional.
>
> So, I'm glad to hear your comments what I could make better ob my
> changes or maybe also, why I should not change it at all.

I see no technical reason why would it be required to make them conditional nor why would it be difficult to add new devices - so what are your problems?


Best regards,

Imre
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list