[kvm-unit-tests PATCH 1/2] riscv: sbi: dbtr: fix enable trigger return code check

Andrew Jones andrew.jones at linux.dev
Wed Sep 30 04:31:15 PDT 2026


On Fri, Mar 13, 2026 at 03:08:30PM +1000, Nicholas Piggin wrote:
> Enabling triggers that are not mapped to a HW debug trigger
> should return SBI_ERR_INVALID_PARAM.
> 
> Signed-off-by: Nicholas Piggin <npiggin at gmail.com>
> ---
>  riscv/sbi-dbtr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/riscv/sbi-dbtr.c b/riscv/sbi-dbtr.c
> index 129f79b8..489242b0 100644
> --- a/riscv/sbi-dbtr.c
> +++ b/riscv/sbi-dbtr.c
> @@ -744,7 +744,7 @@ static void dbtr_test_uninstall_enable(struct sbi_dbtr_shmem_entry *shmem, enum
>  	dbtr_uninstall_trigger();
>  
>  	ret = sbi_debug_enable_triggers(0, 1);
> -	sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_enable_triggers");
> +	sbiret_report_error(&ret, SBI_ERR_INVALID_PARAM, "sbi_debug_enable_triggers");
>  
>  	install_exception_handler(EXC_BREAKPOINT, dbtr_exception_handler);
>  
> -- 
> 2.51.0
>

Reviewed-by: Andrew Jones <andrew.jones at linux.dev>



More information about the opensbi mailing list