[PATCH v2 2/3] lib: sbi: report smrnmi_handlers_init failures instead of ignoring them

[Evgeny Voevodin]

Code looks good to me.

Please, add a note about assumed SBI_E* return value on error in
sbi_platform.h where you change the return type of smrnmi_handlers_init:

      Returns SBI_OK on success, error code otherwise.

Note that comment for rnmi_handler below which says returns SBI_SUCCESS
is not precise. SBI_SUCCESS comes from sbi_ecall_interface.h and it is a
return value of the SBI call, while this callback is called by the
firmware itself and its result never goes to S-mode. sbi_error.h has
SBI_OK for that and the value is the same 0. Maybe worth changing it to
SBI_OK in the same commit or sending as a separate trivial fix.

Reviewed-by: Evgeny Voevodin <evvoevod at tenstorrent.com>

  Thanks,
  Evgeny