[PATCH] lib: utils/irqchip/imsic: Fix the MSI capability assignment

[Rahul Pathak]

On Thu, Oct 1, 2026 at 12:12 PM Prajwal N <prajwal.n at oss.qualcomm.com> wrote:
>
> The struct sbi_irqchip_device is copied to the struct imsic_data
> and the MSI capability is set in sbi_irqchip_device. Since the
> struct assignment is not a pointer, the MSI capability setting
> does not take effect.
>
> Set the MSI capability directly in the struct imsic_data to
> ensure it takes effect.
>
> Fixes: 193b1d9e7ecb ("lib: utils/irqchip/imsic:migrate to irqchip framework")
>
> Signed-off-by: Prajwal N <prajwal.n at oss.qualcomm.com>
> ---
>  lib/utils/irqchip/imsic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/utils/irqchip/imsic.c b/lib/utils/irqchip/imsic.c
> index f6da9f7e..41cfadeb 100644
> --- a/lib/utils/irqchip/imsic.c
> +++ b/lib/utils/irqchip/imsic.c
> @@ -598,7 +598,7 @@ int imsic_cold_irqchip_init(struct imsic_data *imsic)
>
>         imsic->irqchip          = imsic_device;
>         imsic->irqchip.id       = imsic->unique_id;
> -       imsic_device.caps = SBI_IRQCHIP_CAPS_MSI;
> +       imsic->irqchip.caps     = SBI_IRQCHIP_CAPS_MSI;
>         imsic->irqchip.num_hwirq = imsic->num_ids + 1;
>
>         sbi_hartmask_set_all(&imsic->irqchip.target_harts);
> --
> 2.43.0

LGTM

Reviewed-by: Rahul Pathak <rahul.pathak at oss.qualcomm.com>