[PATCH] include/sbi_utils: Fix warm reboot failure

Rahul Pathak rahul.pathak at oss.qualcomm.com
Sun Oct 4 20:12:49 PDT 2026


On Thu, Oct 1, 2026 at 2:15 PM Prajwal N <prajwal.n at oss.qualcomm.com> wrote:
>
> When sbi_system_reset() is invoked with SBI_SRST_RESET_TYPE_WARM_REBOOT,
> the RPMI system reset driver reports warm reboot as unsupported.
>
> The driver was checking the wrong bit in the FLAGS field returned
> by rpmi_sysreset_get_attributes().
>
> Fix: Check the correct bit to detect warm reboot support
>
> Fixes: 6a26726e08e4 (lib/utils: reset: Add RPMI System Reset driver)
>
> Signed-off-by: Prajwal N <prajwal.n at oss.qualcomm.com>
> ---
>  include/sbi_utils/mailbox/rpmi_msgprot.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/sbi_utils/mailbox/rpmi_msgprot.h b/include/sbi_utils/mailbox/rpmi_msgprot.h
> index 7ae4abe0..b473e5f6 100644
> --- a/include/sbi_utils/mailbox/rpmi_msgprot.h
> +++ b/include/sbi_utils/mailbox/rpmi_msgprot.h
> @@ -392,7 +392,7 @@ enum rpmi_sysrst_reset_type {
>         RPMI_SYSRST_TYPE_MAX,
>  };
>
> -#define RPMI_SYSRST_ATTRS_FLAGS_RESETTYPE_POS          (1)
> +#define RPMI_SYSRST_ATTRS_FLAGS_RESETTYPE_POS          (0)
>  #define RPMI_SYSRST_ATTRS_FLAGS_RESETTYPE_MASK         \
>                         (1U << RPMI_SYSRST_ATTRS_FLAGS_RESETTYPE_POS)
>

LGTM

Reviewed-by: Rahul Pathak <rahul.pathak at oss.qualcomm.com>



More information about the opensbi mailing list