[PATCH 2/3] lib: sbi: dbtr: return SBI_ERR_BAD_RANGE for invalid trigger index range

[Anup Patel]

On Tue, Jul 28, 2026 at 12:00 AM David E. Garcia Porras
<david.garcia at aheadcomputing.com> wrote:
>
> sbi_dbtr_read_trig() returns SBI_ERR_INVALID_PARAM for an out-of-range
> trigger index range, where SBI v3.0 section 19.3 defines
> SBI_ERR_BAD_RANGE. Return SBI_ERR_BAD_RANGE, matching the equivalent
> range check in sbi_dbtr_update_trig().
>
> Fixes: 324021423d06 ("lib: sbi: dbtr: Fix update_triggers to match SBI")
> Signed-off-by: David E. Garcia Porras <david.garcia at aheadcomputing.com>

LGTM.

Reviewed-by: Anup Patel <anup at brainfault.org>

Applied this patch to the riscv/opensbi repo.

Thanks,
Anup

> ---
>  lib/sbi/sbi_dbtr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/sbi/sbi_dbtr.c b/lib/sbi/sbi_dbtr.c
> index a04f367d..d06fcaeb 100644
> --- a/lib/sbi/sbi_dbtr.c
> +++ b/lib/sbi/sbi_dbtr.c
> @@ -650,7 +650,7 @@ int sbi_dbtr_read_trig(unsigned long smode,
>
>         if (trig_idx_base >= hs->total_trigs ||
>             trig_idx_base + trig_count >= hs->total_trigs)
> -               return SBI_ERR_INVALID_PARAM;
> +               return SBI_ERR_BAD_RANGE;
>
>         if (sbi_dbtr_shmem_disabled(hs))
>                 return SBI_ERR_NO_SHMEM;
> --
> 2.43.0
>