[PATCH] lib:tests: add bitwise operations unit tests
Anup Patel
anup at brainfault.org
Sun Mar 23 08:43:03 PDT 2025
On Wed, Feb 19, 2025 at 7:28 AM <zhangdongdong at eswincomputing.com> wrote:
>
> From: Dongdong Zhang <zhangdongdong at eswincomputing.com>
>
> * Added bitops_test_suite to objects.mk for including bitwise
> operations tests.
> * Created new file sbi_bitops_test.c containing unit tests for
> various bitwise operations.
You don't need to list the changes in the commit description, rather
provide a brief explanation about what is being done.
>
> Signed-off-by: Dongdong Zhang <zhangdongdong at eswincomputing.com>
Otherwise, this looks good to me. I have taken care of the above
comment at the time of merging this patch.
Reviewed-by: Anup Patel <anup at brainfault.org>
Applied this patch to the riscv/opensbi repo.
Thanks,
Anup
> ---
> lib/sbi/tests/objects.mk | 5 +-
> lib/sbi/tests/sbi_bitops_test.c | 135 ++++++++++++++++++++++++++++++++
> 2 files changed, 139 insertions(+), 1 deletion(-)
> create mode 100644 lib/sbi/tests/sbi_bitops_test.c
>
> diff --git a/lib/sbi/tests/objects.mk b/lib/sbi/tests/objects.mk
> index 16608fa..7e5b964 100644
> --- a/lib/sbi/tests/objects.mk
> +++ b/lib/sbi/tests/objects.mk
> @@ -14,4 +14,7 @@ carray-sbi_unit_tests-$(CONFIG_SBIUNIT) += locks_test_suite
> libsbi-objs-$(CONFIG_SBIUNIT) += tests/riscv_locks_test.o
>
> carray-sbi_unit_tests-$(CONFIG_SBIUNIT) += math_test_suite
> -libsbi-objs-$(CONFIG_SBIUNIT) += tests/sbi_math_test.o
> \ No newline at end of file
> +libsbi-objs-$(CONFIG_SBIUNIT) += tests/sbi_math_test.o
> +
> +carray-sbi_unit_tests-$(CONFIG_SBIUNIT) += bitops_test_suite
> +libsbi-objs-$(CONFIG_SBIUNIT) += tests/sbi_bitops_test.o
> diff --git a/lib/sbi/tests/sbi_bitops_test.c b/lib/sbi/tests/sbi_bitops_test.c
> new file mode 100644
> index 0000000..53b51a9
> --- /dev/null
> +++ b/lib/sbi/tests/sbi_bitops_test.c
> @@ -0,0 +1,135 @@
> +/*
> +* SPDX-License-Identifier: BSD-2-Clause
> +*
> +* Copyright 2025 Beijing ESWIN Computing Technology Co., Ltd.
> +*
> +* Author: Dongdong Zhang <zhangdongdong at eswincomputing.com>
> +*/
> +
> +#include <sbi/sbi_bitops.h>
> +#include <sbi/sbi_unit_test.h>
> +
> +#define BPL BITS_PER_LONG
> +
> +unsigned long bits_to_search = 64;
> +
> +static unsigned long ffb1[] = {};
> +static unsigned long ffb2[] = { 0 };
> +static unsigned long ffb3[] = { 1 };
> +static unsigned long ffb4[] = { 1UL << (BPL - 1) };
> +static unsigned long ffb5[] = { 0, 0x10 };
> +static unsigned long ffb6[] = { 0, 0, 1UL << (BPL - 1) };
> +static unsigned long ffb7[] = { 0, 0, 0, 0x01 };
> +
> +static void find_first_bit_test(struct sbiunit_test_case *test)
> +{
> + SBIUNIT_EXPECT_EQ(test, find_first_bit(ffb1, 0), 0);
> + SBIUNIT_EXPECT_EQ(test, find_first_bit(ffb2, BPL), BPL);
> + SBIUNIT_EXPECT_EQ(test, find_first_bit(ffb3, BPL), 0);
> + SBIUNIT_EXPECT_EQ(test, find_first_bit(ffb4, BPL), BPL - 1);
> + SBIUNIT_EXPECT_EQ(test, find_first_bit(ffb5, 2 * BPL), BPL + 4);
> + SBIUNIT_EXPECT_EQ(test, find_first_bit(ffb6, 3 * BPL),
> + 2 * BPL + BPL - 1);
> + SBIUNIT_EXPECT_EQ(test, find_first_bit(ffb7, 4 * BPL), 3 * BPL);
> +}
> +
> +static unsigned long ffzb1[] = {};
> +static unsigned long ffzb2[] = { ~0UL };
> +static unsigned long ffzb3[] = { ~1UL };
> +static unsigned long ffzb4[] = { ~(1UL << (BPL - 1)) };
> +static unsigned long ffzb5[] = { ~0UL, ~0x10UL };
> +static unsigned long ffzb6[] = { ~0UL, ~0UL, ~(1UL << (BPL - 1)) };
> +static unsigned long ffzb7[] = { ~0UL, ~0UL, ~0UL, ~0x01UL };
> +
> +static void find_first_zero_bit_test(struct sbiunit_test_case *test)
> +{
> + SBIUNIT_ASSERT_EQ(test, find_first_zero_bit(ffzb1, 0), 0);
> + SBIUNIT_ASSERT_EQ(test, find_first_zero_bit(ffzb2, BPL), BPL);
> + SBIUNIT_ASSERT_EQ(test, find_first_zero_bit(ffzb3, BPL), 0);
> + SBIUNIT_ASSERT_EQ(test, find_first_zero_bit(ffzb4, BPL), BPL - 1);
> + SBIUNIT_ASSERT_EQ(test, find_first_zero_bit(ffzb5, 2 * BPL), BPL + 4);
> + SBIUNIT_ASSERT_EQ(test, find_first_zero_bit(ffzb6, 3 * BPL),
> + 2 * BPL + BPL - 1);
> + SBIUNIT_ASSERT_EQ(test, find_first_zero_bit(ffzb7, 4 * BPL), 3 * BPL);
> +}
> +
> +static unsigned long flb1[] = {};
> +static unsigned long flb2[] = { 0 };
> +static unsigned long flb3[] = { 1 };
> +static unsigned long flb4[] = { 1UL << (BPL - 1) };
> +static unsigned long flb5[] = { 0, 0x10 };
> +static unsigned long flb6[] = { 0, 0, 1UL << (BPL - 1) };
> +static unsigned long flb7[] = { 0, 0, 0, 0x01 };
> +
> +static void find_last_bit_test(struct sbiunit_test_case *test)
> +{
> + SBIUNIT_EXPECT_EQ(test, find_last_bit(flb1, 0), 0);
> + SBIUNIT_EXPECT_EQ(test, find_last_bit(flb2, BPL), BPL);
> + SBIUNIT_EXPECT_EQ(test, find_last_bit(flb3, BPL), 0);
> + SBIUNIT_EXPECT_EQ(test, find_last_bit(flb4, BPL), BPL - 1);
> + SBIUNIT_EXPECT_EQ(test, find_last_bit(flb5, 2 * BPL), BPL + 4);
> + SBIUNIT_EXPECT_EQ(test, find_last_bit(flb6, 3 * BPL),
> + 2 * BPL + BPL - 1);
> + SBIUNIT_EXPECT_EQ(test, find_last_bit(flb7, 4 * BPL), 3 * BPL);
> +}
> +
> +static unsigned long fnb1[] = {};
> +static unsigned long fnb2[] = { 0 };
> +static unsigned long fnb3[] = { 1 };
> +static unsigned long fnb4[] = { 1UL << (BPL - 1) };
> +static unsigned long fnb5[] = { 0, 0x10 };
> +static unsigned long fnb6[] = { 0, 0, 1UL << (BPL - 1) };
> +static unsigned long fnb7[] = { 0, 0, 0, 0x01 };
> +
> +static void find_next_bit_test(struct sbiunit_test_case *test)
> +{
> + SBIUNIT_EXPECT_EQ(test, find_next_bit(fnb1, 0, 0), 0);
> + SBIUNIT_EXPECT_EQ(test, find_next_bit(fnb2, BPL, 0), BPL);
> + SBIUNIT_EXPECT_EQ(test, find_next_bit(fnb3, BPL, 0), 0);
> + SBIUNIT_EXPECT_EQ(test, find_next_bit(fnb4, BPL, 0), BPL - 1);
> + SBIUNIT_EXPECT_EQ(test, find_next_bit(fnb5, 2 * BPL, 0), BPL + 4);
> + SBIUNIT_EXPECT_EQ(test, find_next_bit(fnb6, 3 * BPL, 0),
> + 2 * BPL + BPL - 1);
> + SBIUNIT_EXPECT_EQ(test, find_next_bit(fnb7, 4 * BPL, 0), 3 * BPL);
> + SBIUNIT_EXPECT_EQ(test, find_next_bit(fnb5, 2 * BPL, BPL), BPL + 4);
> + SBIUNIT_EXPECT_EQ(test, find_next_bit(fnb7, 4 * BPL, 3 * BPL), 3 * BPL);
> + SBIUNIT_EXPECT_EQ(test, find_next_bit(fnb6, 3 * BPL, BPL),
> + 2 * BPL + BPL - 1);
> +}
> +
> +static unsigned long fnzb1[] = {};
> +static unsigned long fnzb2[] = { ~0UL };
> +static unsigned long fnzb3[] = { ~1UL };
> +static unsigned long fnzb4[] = { ~(1UL << (BPL - 1)) };
> +static unsigned long fnzb5[] = { ~0UL, ~0x10UL };
> +static unsigned long fnzb6[] = { ~0UL, ~0UL, ~(1UL << (BPL - 1)) };
> +static unsigned long fnzb7[] = { ~0UL, ~0UL, ~0UL, ~0x01UL };
> +
> +static void find_next_zero_bit_test(struct sbiunit_test_case *test)
> +{
> + SBIUNIT_EXPECT_EQ(test, find_next_zero_bit(fnzb1, 0, 0), 0);
> + SBIUNIT_EXPECT_EQ(test, find_next_zero_bit(fnzb2, BPL, 0), BPL);
> + SBIUNIT_EXPECT_EQ(test, find_next_zero_bit(fnzb3, BPL, 0), 0);
> + SBIUNIT_EXPECT_EQ(test, find_next_zero_bit(fnzb4, BPL, 0), BPL - 1);
> + SBIUNIT_EXPECT_EQ(test, find_next_zero_bit(fnzb5, 2 * BPL, 0), BPL + 4);
> + SBIUNIT_EXPECT_EQ(test, find_next_zero_bit(fnzb6, 3 * BPL, 0),
> + 2 * BPL + BPL - 1);
> + SBIUNIT_EXPECT_EQ(test, find_next_zero_bit(fnzb7, 4 * BPL, 0), 3 * BPL);
> + SBIUNIT_EXPECT_EQ(test, find_next_zero_bit(fnzb5, 2 * BPL, BPL),
> + BPL + 4);
> + SBIUNIT_EXPECT_EQ(test, find_next_zero_bit(fnzb7, 4 * BPL, 3 * BPL),
> + 3 * BPL);
> + SBIUNIT_EXPECT_EQ(test, find_next_zero_bit(fnzb6, 3 * BPL, BPL),
> + 2 * BPL + BPL - 1);
> +}
> +
> +static struct sbiunit_test_case bitops_test_cases[] = {
> + SBIUNIT_TEST_CASE(find_first_bit_test),
> + SBIUNIT_TEST_CASE(find_first_zero_bit_test),
> + SBIUNIT_TEST_CASE(find_last_bit_test),
> + SBIUNIT_TEST_CASE(find_next_bit_test),
> + SBIUNIT_TEST_CASE(find_next_zero_bit_test),
> + SBIUNIT_END_CASE,
> +};
> +
> +SBIUNIT_TEST_SUITE(bitops_test_suite, bitops_test_cases);
> --
> 2.17.1
>
>
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi
More information about the opensbi
mailing list