[PATCH] platform: andes: Fix license to compatible GPL

Xiang W wxjstz at 126.com
Sun Jul 27 22:33:39 PDT 2025


在 2025-07-28一的 10:41 +0530,Anup Patel写道:
> On Mon, Jul 28, 2025 at 10:34 AM Jessica Clarke <jrtc27 at jrtc27.com> wrote:
> > 
> > On 28 Jul 2025, at 05:55, Xiang W <wxjstz at 126.com> wrote:
> > > 
> > > Since platform/generic/include/andes/andes.h and
> > > platform/generic/include/andes/andes_pma.h are licensed under the
> > > GPL, any C files that use them should also be modified to comply
> > > with the GPL. Otherwise, there may be potential legal issues.
> > 
> > Firstly, that’s not how licenses work. The combined work is GPL, but
> > that doesn’t mean these files are. They can be BSD, and should be,
> > because that’s what they were contributed under.
> > 
> > Secondly, why are there GPL’ed files in OpenSBI? It’s a BSD-licensed
> > project, and anything else* is problematic for vendors. Especially for
> > source files that are included by default in the generic platform build.
> > 
> > So a hard NAK from me, and a call to delete the GPL’ed Andes files or
> > replace them with BSD-licensed ones (which can just be getting the
> > author(s) to relicense them). I doubt there’s anything interesting in
> > them anyway.
> 
> I agree with Jessica on this. Lets not have any non-permissive
> sources in OpenSBI.
> 
> The Andes headers have been overlooked in patch reviews so
> I suggest updating these headers to use BSD-license.
> 
> Regards,
> Anup
Yes, I agree too. We need a review from the original author.

New patch at:
https://patchwork.ozlabs.org/project/opensbi/patch/20250728052713.361094-1-wxjstz@126.com/

Regards,
Xiang W


> > 
> > Jess
> > 
> > * Well, anything copyleft / non-permissive
> > 
> > > Signed-off-by: Xiang W <wxjstz at 126.com>
> > > ---
> > > platform/generic/andes/ae350.c     | 2 +-
> > > platform/generic/andes/andes_pmu.c | 2 +-
> > > platform/generic/andes/andes_sbi.c | 2 +-
> > > platform/generic/andes/sleep.S     | 2 +-
> > > 4 files changed, 4 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/platform/generic/andes/ae350.c b/platform/generic/andes/ae350.c
> > > index f06e207d..880d5803 100644
> > > --- a/platform/generic/andes/ae350.c
> > > +++ b/platform/generic/andes/ae350.c
> > > @@ -1,5 +1,5 @@
> > > /*
> > > - * SPDX-License-Identifier: BSD-2-Clause
> > > + * SPDX-License-Identifier: GPL-2.0
> > >  *
> > >  * Copyright (c) 2022 Andes Technology Corporation
> > >  *
> > > diff --git a/platform/generic/andes/andes_pmu.c b/platform/generic/andes/andes_pmu.c
> > > index 9eee4edc..6099a73b 100644
> > > --- a/platform/generic/andes/andes_pmu.c
> > > +++ b/platform/generic/andes/andes_pmu.c
> > > @@ -1,4 +1,4 @@
> > > -// SPDX-License-Identifier: BSD-2-Clause
> > > +// SPDX-License-Identifier: GPL-2.0
> > > /*
> > >  * andes_pmu.c - Andes PMU device callbacks and platform overrides
> > >  *
> > > diff --git a/platform/generic/andes/andes_sbi.c b/platform/generic/andes/andes_sbi.c
> > > index f68ac908..6c155e10 100644
> > > --- a/platform/generic/andes/andes_sbi.c
> > > +++ b/platform/generic/andes/andes_sbi.c
> > > @@ -1,4 +1,4 @@
> > > -// SPDX-License-Identifier: BSD-2-Clause
> > > +// SPDX-License-Identifier: GPL-2.0
> > > /*
> > >  * Copyright (C) 2023 Renesas Electronics Corp.
> > >  *
> > > diff --git a/platform/generic/andes/sleep.S b/platform/generic/andes/sleep.S
> > > index 361aff3a..967fdaef 100644
> > > --- a/platform/generic/andes/sleep.S
> > > +++ b/platform/generic/andes/sleep.S
> > > @@ -1,5 +1,5 @@
> > > /*
> > > - * SPDX-License-Identifier: BSD-2-Clause
> > > + * SPDX-License-Identifier: GPL-2.0
> > >  *
> > >  * Copyright (c) 2023 Andes Technology Corporation
> > >  *
> > > --
> > > 2.47.2
> > > 
> > > 
> > > --
> > > opensbi mailing list
> > > opensbi at lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/opensbi
> > 




More information about the opensbi mailing list