[PATCH] lib: utils: Make the enforce permission bit configurable from DT

Xiang W wxjstz at 126.com
Tue Jan 7 18:25:38 PST 2025


在 2025-01-07二的 02:43 +0000,Chao Du写道:
> The domain_support.md documentation states that the enforce permission
> bit (BIT[6]) could be set in the "regions" property of a domain
> instance DT node. However, this bit is masked in the current
> implementation. This patch unmasks the bit to make it configurable
> from DT.
> 
> Signed-off-by: Chao Du <duchao at eswincomputing.com>
look good to me.

Reviewed-by: Xiang W <wxjstz at 126.com>
> ---
>  lib/utils/fdt/fdt_domain.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/utils/fdt/fdt_domain.c b/lib/utils/fdt/fdt_domain.c
> index 4bc7ed8..d7efc56 100644
> --- a/lib/utils/fdt/fdt_domain.c
> +++ b/lib/utils/fdt/fdt_domain.c
> @@ -289,8 +289,10 @@ static int __fdt_parse_region(const void *fdt, int domain_offset,
>  		return SBI_EINVAL;
>  	order = val32;
>  
> +	flags = region_access & (SBI_DOMAIN_MEMREGION_ACCESS_MASK
> +				| SBI_DOMAIN_MEMREGION_ENF_PERMISSIONS);
> +
>  	/* Read "mmio" DT property */
> -	flags = region_access & SBI_DOMAIN_MEMREGION_ACCESS_MASK;
>  	if (fdt_get_property(fdt, region_offset, "mmio", NULL))
>  		flags |= SBI_DOMAIN_MEMREGION_MMIO;
>  
> -- 
> 2.34.1
> 
> 




More information about the opensbi mailing list