[PATCH] firmware: fw_base.S: Fix comments for _wait_for_boot_hart

Anup Patel anup at brainfault.org
Tue Feb 11 20:05:43 PST 2025


On Mon, Jan 20, 2025 at 8:44 AM Xiang W <wxjstz at 126.com> wrote:
>
> Due to some historical issues, the value of BOOT_STATUS_BOOT_HART_DONE
> has changed and the comment message needs to be corrected.
>
> Signed-off-by: Xiang W <wxjstz at 126.com>

LGTM.

Reviewed-by: Anup Patel <anup at brainfault.org>

Applied this patch to the riscv/opensbi repo.

Thanks,
Anup

> ---
>  firmware/fw_base.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/firmware/fw_base.S b/firmware/fw_base.S
> index d027e5e2..536bcd26 100644
> --- a/firmware/fw_base.S
> +++ b/firmware/fw_base.S
> @@ -292,7 +292,7 @@ _fdt_reloc_done:
>         REG_S   t0, 0(t1)
>         j       _start_warm
>
> -       /* waiting for boot hart to be done (_boot_status == 2) */
> +       /* waiting for boot hart to be done (_boot_status == BOOT_STATUS_BOOT_HART_DONE) */
>  _wait_for_boot_hart:
>         li      t0, BOOT_STATUS_BOOT_HART_DONE
>         lla     t1, _boot_status
> --
> 2.45.2
>



More information about the opensbi mailing list