[PATCH 6/8] lib: sbi_hart: reset mstateen0

[Anup Patel]

On Tue, Apr 15, 2025 at 8:13 PM Radim Krčmář <rkrcmar at ventanamicro.com> wrote:
>
> The current logic clears some bits based on SBI known extensions.
> Be safe and do not leave enabled anything that SBI doesn't control.
>
> This is not a breaking change, because the register must be initialized
> to 0 by the ISA on reset, but it is better to not depend on it when we
> don't need to.
>
> Signed-off-by: Radim Krčmář <rkrcmar at ventanamicro.com>

LGTM.

Reviewed-by: Anup Patel <anup at brainfault.org>

Regards,
Anup

> ---
>  lib/sbi/sbi_hart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/sbi/sbi_hart.c b/lib/sbi/sbi_hart.c
> index b209f1cab27d..569f8008b523 100644
> --- a/lib/sbi/sbi_hart.c
> +++ b/lib/sbi/sbi_hart.c
> @@ -89,7 +89,7 @@ static void mstatus_init(struct sbi_scratch *scratch)
>                 csr_write(CSR_HSTATUS, 0);
>
>         if (sbi_hart_has_extension(scratch, SBI_HART_EXT_SMSTATEEN)) {
> -               mstateen_val = csr_read64(CSR_MSTATEEN0);
> +               mstateen_val = 0;
>                 mstateen_val |= SMSTATEEN_STATEN;
>                 mstateen_val |= SMSTATEEN0_CONTEXT;
>                 mstateen_val |= SMSTATEEN0_HSENVCFG;
> --
> 2.48.1
>
>
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi