[PATCH] lib: utils/irqchip: always parse msi information for each aplic device

[Inochi Amaoto]

On Wed, Apr 23, 2025 at 11:31:22AM +0000, Yao Zi wrote:
> On Wed, Apr 23, 2025 at 04:09:14PM +0800, Inochi Amaoto wrote:
> > For a root domain, it may keep direct delivery mode as its subdomains
> > use msi to delivery interrupt. The currect parsing logic may lost this
> 
> Grammar: may lost -> may lose
> 
> > information and break the system if the domain is not set as MSI mode
> > or the MSI domain is not a direct children of the root domain.
> > 
> > For a non-root domain, it is safe to parse the MSI information of all
> > its domain and write the msiaddrcfg register. The bus should ignore the
> 
> Should "all its domain" be "all its subdomains"? This sentence is a
> little confusing.
> 

Yeah, it should be subdomains.

> > write on this readonly address.
> > 
> > Parse the aplic MSI information recursively for all aplic device.
> > 
> > Signed-off-by: Inochi Amaoto <inochiama at gmail.com>
> > ---
> >  lib/utils/fdt/fdt_helper.c | 138 ++++++++++++++++++-------------------
> >  1 file changed, 69 insertions(+), 69 deletions(-)
> > 
> > diff --git a/lib/utils/fdt/fdt_helper.c b/lib/utils/fdt/fdt_helper.c
> > index 8939d90..0150725 100644
> > --- a/lib/utils/fdt/fdt_helper.c
> > +++ b/lib/utils/fdt/fdt_helper.c
> > @@ -6,6 +6,8 @@
> >   * Copyright (C) 2020 Bin Meng <bmeng.cn at gmail.com>
> >   */
> >  
> > +#include "sbi/sbi_error.h"
> > +#include "sbi/sbi_types.h"
> 
> I'd like to keep the including style consistent and sorted.
> 

Oh, I miss this. I think this is inserted by clangd plugin.
And they should be removed.

Regards,
Inochi