[PATCH 01/12] lib: sbi_init: Remove obsolete hartid check

[Anup Patel]

On Fri, Aug 30, 2024 at 9:19 PM Samuel Holland
<samuel.holland at sifive.com> wrote:
>
> This check has been obsolete since commit c51f02cf143b ("include:
> sbi_platform: Introduce HART index to HART id table"). It originally
> filtered out harts that were disabled in the FDT, but those harts are
> omitted from the hart_index2id table, so they will hang in fw_base.S
> after the "Find HART index" loop and never enter sbi_init().
>
> Signed-off-by: Samuel Holland <samuel.holland at sifive.com>

LGTM.

Reviewed-by: Anup Patel <anup at brainfault.org>

Applied this patch to the riscv/opensbi repo.

Thanks,
Anup

> ---
>
>  lib/sbi/sbi_init.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/lib/sbi/sbi_init.c b/lib/sbi/sbi_init.c
> index d80efe97..7443010e 100644
> --- a/lib/sbi/sbi_init.c
> +++ b/lib/sbi/sbi_init.c
> @@ -500,21 +500,11 @@ static atomic_t coldboot_lottery = ATOMIC_INITIALIZER(0);
>   */
>  void __noreturn sbi_init(struct sbi_scratch *scratch)
>  {
> -       u32 i, h;
> -       bool hartid_valid               = false;
>         bool next_mode_supported        = false;
>         bool coldboot                   = false;
>         u32 hartid                      = current_hartid();
>         const struct sbi_platform *plat = sbi_platform_ptr(scratch);
>
> -       for (i = 0; i < plat->hart_count; i++) {
> -               h = (plat->hart_index2id) ? plat->hart_index2id[i] : i;
> -               if (h == hartid)
> -                       hartid_valid = true;
> -       }
> -       if (!hartid_valid)
> -               sbi_hart_hang();
> -
>         switch (scratch->next_mode) {
>         case PRV_M:
>                 next_mode_supported = true;
> --
> 2.45.1
>
>
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi