[PATCH 1/2] include: sbi_domain: Fix incorrect comments

Anup Patel anup at brainfault.org
Fri Sep 20 09:16:34 PDT 2024


On Fri, Aug 30, 2024 at 1:16 AM Samuel Holland
<samuel.holland at sifive.com> wrote:
>
> These comments are inaccurate as of commit db56341dfa1f ("lib: sbi:
> Allow platforms to provide root domain memory regions"), which modified
> root domain registration to go through sbi_domain_register() like other
> domains.
>
> Fixes: db56341dfa1f ("lib: sbi: Allow platforms to provide root domain memory regions")
> Signed-off-by: Samuel Holland <samuel.holland at sifive.com>

LGTM.

Reviewed-by: Anup Patel <anup at brainfault.org>

Applied this patch to the riscv/opensbi repo.

Thanks,
Anup

> ---
>
>  include/sbi/sbi_domain.h | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/include/sbi/sbi_domain.h b/include/sbi/sbi_domain.h
> index a6e99c63..34ebd39d 100644
> --- a/include/sbi/sbi_domain.h
> +++ b/include/sbi/sbi_domain.h
> @@ -163,16 +163,9 @@ struct sbi_domain_memregion {
>
>  /** Representation of OpenSBI domain */
>  struct sbi_domain {
> -       /**
> -        * Logical index of this domain
> -        * Note: This set by sbi_domain_finalize() in the coldboot path
> -        */
> +       /** Logical index of this domain */
>         u32 index;
> -       /**
> -        * HARTs assigned to this domain
> -        * Note: This set by sbi_domain_init() and sbi_domain_finalize()
> -        * in the coldboot path
> -        */
> +       /** HARTs assigned to this domain */
>         struct sbi_hartmask assigned_harts;
>         /** Spinlock for accessing assigned_harts */
>         spinlock_t assigned_harts_lock;
> --
> 2.45.1
>
>
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi



More information about the opensbi mailing list