[PATCH 0/2] lib: sbi: fixes a few SSE errors

Clément Léger cleger at rivosinc.com
Fri Nov 29 06:41:26 PST 2024



On 29/11/2024 04:14, Anup Patel wrote:
> On Mon, Nov 25, 2024 at 4:24 PM Clément Léger <cleger at rivosinc.com> wrote:
>>
>> While reviewing kvm-unit-tests, Andrew Jones found a few implementation
>> errors. This small series fixes them.
>>
>> Clément Léger (2):
>>   lib: sbi: fix GLOBAL_PLAT_DEFINE
>>   lib: sbi: sse: Fix a6 and a7 register content upon injection
> 
> Do you have corresponding changes in Linux SSE implementation ?

Yes, see my branch on github, I just rebased it on master this week:

https://github.com/rivosinc/linux/tree/dev/cleger/sse


> 
> Recently, we had found few more issues and fixed the Linux SSE
> implementation which is available in dev-upstream branch at:
> https://github.com/ventanamicro/linux.git
> 
> Particularly, the Linux SSE entry/exit was not saving and restoring
> sscratch CSR in all paths which caused the kernel to crash in certain
> cases. The above mentioned branch already has the fix for it.

Yeah, I already fixed that in june and it was pushed on my branch
dev/cleger/sse on github at that time. I also have a KVM SSE
implementation on another branch.

I'll submit Linux SSE for review next week and I'have backported the PM
notifier/ mask/unmask stuff from your branch. Whom did that work so I
can credit him with a Co-Developed-by tag ?

I did not saw any other modifications though. For GHES, this seems to be
a separate commit so I'll let that to Himanchu of course.

Thanks,

Clément

> 
> Regards,
> Anup




More information about the opensbi mailing list