[PATCH v2 03/11] scripts/carray.sh: Avoid useless use of cat

Ben Dooks ben.dooks at codethink.co.uk
Thu Nov 28 09:45:37 PST 2024


On 28/11/2024 12:36, Anup Patel wrote:
> On Thu, Nov 28, 2024 at 6:05 PM Ben Dooks <ben.dooks at codethink.co.uk> wrote:
>>
>> On 28/11/2024 12:33, Anup Patel wrote:
>>> On Tue, Nov 12, 2024 at 3:33 AM Samuel Holland
>>> <samuel.holland at sifive.com> wrote:
>>>>
>>>> awk(1) takes input files as positional arguments, so there is no need
>>>> to read the file with cat(1).
>>>>
>>>> Signed-off-by: Samuel Holland <samuel.holland at sifive.com>
>>>
>>> LGTM.
>>>
>>> Reviewed-by: Anup Patel <anup at brainfault.org>
>>>
>>> Regards,
>>> Anup
>>>
>>
>> Should I follow up with my patch to just make this one awk script?
> 
> Yes, please rebase and send v2 of your patch.

Ok, I've been having a test with latest git, got the fixups and changes
for the work Samuel did done and a diff against PLATFORM=generic build
done to check the build didn't get broken.

I'll probably put a new version out tomorrow

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html



More information about the opensbi mailing list