[PATCH v2 03/11] scripts/carray.sh: Avoid useless use of cat

Ben Dooks ben.dooks at codethink.co.uk
Thu Nov 28 04:35:31 PST 2024


On 28/11/2024 12:33, Anup Patel wrote:
> On Tue, Nov 12, 2024 at 3:33 AM Samuel Holland
> <samuel.holland at sifive.com> wrote:
>>
>> awk(1) takes input files as positional arguments, so there is no need
>> to read the file with cat(1).
>>
>> Signed-off-by: Samuel Holland <samuel.holland at sifive.com>
> 
> LGTM.
> 
> Reviewed-by: Anup Patel <anup at brainfault.org>
> 
> Regards,
> Anup
> 

Should I follow up with my patch to just make this one awk script?

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html



More information about the opensbi mailing list