[PATCH v2 1/2] platform: ensure enough heap size with debug triggers extension

[Inochi Amaoto]

On Sat, Nov 09, 2024 at 02:24:42PM +0530, Anup Patel wrote:
> On Fri, Sep 20, 2024 at 1:09 PM Inochi Amaoto <inochiama at gmail.com> wrote:
> >
> > DBTR introduce a big heap allocation to store hart state, this is
> > allocated percpu and needs big space when CPU number is high.
> >
> > Increase the percpu part to fix this problem, and decrease the
> > fixed part to avoid too big heap size.
> >
> > Fixes: 97f234f (lib: sbi: Introduce the SBI debug triggers extension support)
> > Signed-off-by: Inochi Amaoto <inochiama at gmail.com>
> > Reviewed-by: Xiang W <wxjstz at 126.com>
> > ---
> >  include/sbi/sbi_platform.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/sbi/sbi_platform.h b/include/sbi/sbi_platform.h
> > index 7b3ac4b..d1c556c 100644
> > --- a/include/sbi/sbi_platform.h
> > +++ b/include/sbi/sbi_platform.h
> > @@ -152,7 +152,7 @@ struct sbi_platform_operations {
> >
> >  /** Platform default heap size */
> >  #define SBI_PLATFORM_DEFAULT_HEAP_SIZE(__num_hart)     \
> > -                                       (0x8000 + 0x800 * (__num_hart))
> > +                                       (0x4000 + 0x2000 * (__num_hart))
> 
> The per-HART DTBR state is 1536 bytes so I don't see the point
> in such an arbitrary increase.
> 
> How about below ?
> 
>  #define SBI_PLATFORM_DEFAULT_HEAP_SIZE(__num_hart)     \
> -                                       (0x8000 + 0x800 * (__num_hart))
> +                                       (0x8000 + 0x1000 * (__num_hart))
> 
> Regards,
> Anup
> 

Yeah, it is OK for me. I will change the formula to 0x1000 per hart,
thanks.

Regards,
Inochi

> >
> >  /** Representation of a platform */
> >  struct sbi_platform {
> > --
> > 2.46.1
> >
> >
> > --
> > opensbi mailing list
> > opensbi at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/opensbi