[PATCH v4 3/4] lib: tests: Add a test for sbi_bitmap

Ivan Orlov ivan.orlov0322 at gmail.com
Sun Mar 10 13:17:35 PDT 2024


On 3/10/24 04:50, Anup Patel wrote:
> On Tue, Mar 5, 2024 at 3:15 AM Ivan Orlov <ivan.orlov0322 at gmail.com> wrote:
>>
>> Add test suite covering all of the functions from lib/sbi/sbi_bitmap.c:
>> __bitmap_and, __bitmap_or and __bitmap_xor.
>>
>> Signed-off-by: Ivan Orlov <ivan.orlov0322 at gmail.com>
>> Reviewed-by: Andrew Jones <ajones at ventanamicro.com>
> 
> This sbi_bitmap_test.c fails to compile for RV32 due the "u64"
> variables. I have fixed this at the time of merging this patch.
> 
> Applied this patch to the riscv/opensb repo.
> 

Thank you for fixing this error, I'll try to set up the proper test 
tooling/infrastructure to avoid such mistakes in the future.

Actually, I was thinking about a python script for the test automation, 
similar to what we have in the Linux Kernel for KUnit. For instance, it 
could run the tests for the multiple XLENs and extension sets and report 
results in a nice format.

-- 
Kind regards,
Ivan Orlov




More information about the opensbi mailing list