[PATCH 2/2] lib: sbi: fwft: return SBI_EINVAL rather than SBI_ERR_INVALID_PARAM

Andrew Jones ajones at ventanamicro.com
Tue Jun 25 03:07:06 PDT 2024


On Mon, Jun 24, 2024 at 12:29:09PM GMT, Clément Léger wrote:
> Error code returned by the ecall handles should use the defines from
> sbi_ecall_interface.h rather than sbi_error.h.
> 
> Signed-off-by: Clément Léger <cleger at rivosinc.com>
> ---
>  lib/sbi/sbi_fwft.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/sbi/sbi_fwft.c b/lib/sbi/sbi_fwft.c
> index 595819b..f1ae915 100644
> --- a/lib/sbi/sbi_fwft.c
> +++ b/lib/sbi/sbi_fwft.c
> @@ -196,7 +196,7 @@ int sbi_fwft_set(enum sbi_fwft_feature_t feature, unsigned long value,
>  		return ret;
>  
>  	if ((flags & ~SBI_FWFT_SET_FLAG_LOCK) != 0)
> -		return SBI_ERR_INVALID_PARAM;
> +		return SBI_EINVAL;
>  
>  	if (conf->flags & SBI_FWFT_SET_FLAG_LOCK)
>  		return SBI_EDENIED;
> -- 
> 2.45.2
>

Reviewed-by: Andrew Jones <ajones at ventanamicro.com>



More information about the opensbi mailing list