[PATCH v2, 1/1] util: atcsmu.c: fix typo and coding style

Leo Liang ycliang at andestech.com
Tue Jul 30 20:34:59 PDT 2024


On Wed, Jul 31, 2024 at 04:24:42AM +0100, Jessica Clarke wrote:
> [EXTERNAL MAIL]
> 
> On 31 Jul 2024, at 03:58, Leo Yu-Chi Liang <ycliang at andestech.com> wrote:
> >
> > Fix typo "hard -> hart", printf format and if statement coding style.
> >
> > Signed-off-by: Leo Yu-Chi Liang <ycliang at andestech.com>
> > Reviewed-by: Yu Chien Peter Lin <peterlin at andestech.com>
> 
> 1. Don’t combine changes like this, it makes it hard to see what’s just
> a style change and what’s a behavioural change.
> 
> 2. Early return is often better code like in these cases, but it’s not
> like the existing code is wrong style-wise or hard to read.
> 
> Jess

Hi Jess,

Thanks for the review.
I will split these changes into two patches, 
modify the wording of the commit messages and send a v3 patch ASAP.

Best regards,
Leo



More information about the opensbi mailing list