[PATCH v2 2/3] lib: sbi: dump logs when crash

Anup Patel anup at brainfault.org
Thu Jul 4 23:55:19 PDT 2024


On Mon, Jun 24, 2024 at 7:49 PM Xiang W <wxjstz at 126.com> wrote:
>
> When opensbi crashes, try to initialize the console in order to
> output error messages.
>
> Signed-off-by: Xiang W <wxjstz at 126.com>
> ---
>  lib/sbi/sbi_hart.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/lib/sbi/sbi_hart.c b/lib/sbi/sbi_hart.c
> index c366701..48ec97c 100644
> --- a/lib/sbi/sbi_hart.c
> +++ b/lib/sbi/sbi_hart.c
> @@ -1010,6 +1010,10 @@ int sbi_hart_init(struct sbi_scratch *scratch, bool cold_boot)
>
>  void __attribute__((noreturn)) sbi_hart_hang(void)
>  {
> +       /* Try to initialize the console to output some error messages */
> +       if (sbi_console_get_device() == NULL)
> +               sbi_console_init(sbi_scratch_thishart_ptr());
> +

If a crash happened early then this will again change the order
in which platform console_init() is called as compared to other
functions in init_coldboot().

>         while (1)
>                 wfi();
>         __builtin_unreachable();
> --
> 2.43.0
>

Regards,
Anup



More information about the opensbi mailing list