[PATCH 1/4] scripts/carray.sh: Add comment to generated files

Anup Patel anup at brainfault.org
Wed Jul 3 22:49:30 PDT 2024


On Mon, Jul 1, 2024 at 7:57 PM Ben Dooks <ben.dooks at codethink.co.uk> wrote:
>
> From: Ivan Orlov <ivan.orlov0322 at gmail.com>
>
> Add a comment about where auto-generated file came from to the carray.sh
> output. This should help avoiding confusion for the developers looking
> at the build artifacts and finding .c files there.
>
> Signed-off-by: Ivan Orlov <ivan.orlov0322 at gmail.com>
> Reviewed-by: Andrew Jones <ajones at ventanamicro.com>
> Signed-off-by: Ben Dooks <ben.dooks at codethink.co.uk>

LGTM.

Reviewed-by: Anup Patel <anup at brainfault.org>

Applied this patch to the riscv/opensbi repo.

Thanks,
Anup

> ---
>  scripts/carray.sh | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/scripts/carray.sh b/scripts/carray.sh
> index 13f9d36..1fa2366 100755
> --- a/scripts/carray.sh
> +++ b/scripts/carray.sh
> @@ -61,6 +61,7 @@ if [ -z "${ARRAY_NAME}" ]; then
>         usage
>  fi
>
> +printf "// Generated with $(basename $0) from $(basename ${CONFIG_FILE})\n"
>  printf "#include <%s>\n\n" "${TYPE_HEADER}"
>
>  for VAR in ${VAR_LIST}; do
> --
> 2.37.2.352.g3c44437643
>
>
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi



More information about the opensbi mailing list