[PATCH] lib: utils/irqchip: Optimize `fdt_parse_aplic_node` function

Huang Borong huangborong at bosc.ac.cn
Tue Dec 31 00:12:23 PST 2024


- Remove redundant memset for the "aplic" parameter
- Initialize "imsic" with zero

Signed-off-by: Huang Borong <huangborong at bosc.ac.cn>
---
 lib/utils/fdt/fdt_helper.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/utils/fdt/fdt_helper.c b/lib/utils/fdt/fdt_helper.c
index cb350e5..e92484c 100644
--- a/lib/utils/fdt/fdt_helper.c
+++ b/lib/utils/fdt/fdt_helper.c
@@ -630,14 +630,13 @@ int fdt_parse_aplic_node(const void *fdt, int nodeoff, struct aplic_data *aplic)
 	bool child_found;
 	const fdt32_t *val;
 	const fdt32_t *del;
-	struct imsic_data imsic;
+	struct imsic_data imsic = { 0 };
 	int i, j, d, dcnt, len, noff, rc;
 	uint64_t reg_addr, reg_size;
 	struct aplic_delegate_data *deleg;
 
 	if (nodeoff < 0 || !aplic || !fdt)
 		return SBI_ENODEV;
-	memset(aplic, 0, sizeof(*aplic));
 
 	rc = fdt_get_node_addr_size(fdt, nodeoff, 0, &reg_addr, &reg_size);
 	if (rc < 0 || !reg_addr || !reg_size)
-- 
2.34.1




More information about the opensbi mailing list