[PATCH v2] lib: utils/serial: Optimize semihosting_putc implementation
cp0613 at linux.alibaba.com
cp0613 at linux.alibaba.com
Tue Oct 17 19:42:05 PDT 2023
From: Chen Pei <cp0613 at linux.alibaba.com>
For some debuggers that do not implement SYSWRITEC and SYSREADC
operations, we can use SYSWRITE and SYSREAD instead like the
implementation of semihosting_getc().
Signed-off-by: Chen Pei <cp0613 at linux.alibaba.com>
Reviewed-by: Xiang W <wxjstz at 126.com>
Changed from v1:
1. simplified by calling semihosting_puts directly.
---
lib/utils/serial/semihosting.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/utils/serial/semihosting.c b/lib/utils/serial/semihosting.c
index ce65887..a27c69e 100644
--- a/lib/utils/serial/semihosting.c
+++ b/lib/utils/serial/semihosting.c
@@ -160,11 +160,6 @@ static long semihosting_write(long fd, const void *memp, size_t len)
/* clang-format on */
-static void semihosting_putc(char ch)
-{
- semihosting_trap(SYSWRITEC, &ch);
-}
-
static unsigned long semihosting_puts(const char *str, unsigned long len)
{
char ch;
@@ -183,6 +178,11 @@ static unsigned long semihosting_puts(const char *str, unsigned long len)
return (ret < 0) ? 0 : ret;
}
+static void semihosting_putc(char ch)
+{
+ semihosting_puts(&ch, 1);
+}
+
static int semihosting_getc(void)
{
char ch = 0;
--
2.25.1
More information about the opensbi
mailing list