[PATCH v2] lib: utils/serial: Optimize semihosting_putc implementation

[Xiang W]

在 2023-11-16星期四的 11:42 +0530，Anup Patel写道：
> On Wed, Oct 18, 2023 at 8:12 AM <cp0613 at linux.alibaba.com> wrote:
> > 
> > From: Chen Pei <cp0613 at linux.alibaba.com>
> > 
> > For some debuggers that do not implement SYSWRITEC and SYSREADC
> > operations, we can use SYSWRITE and SYSREAD instead like the
> > implementation of semihosting_getc().
> > 
> > Signed-off-by: Chen Pei <cp0613 at linux.alibaba.com>
> > Reviewed-by: Xiang W <wxjstz at 126.com>
> 
> Looks good to me.
> 
> Reviewed-by: Anup Patel <anup at brainfault.org>
> 
> Applied this patch to the riscv/opensbi repo.
I submitted a new workaround.

https://patchwork.ozlabs.org/project/opensbi/patch/20231025043104.748104-1-wxjstz@126.com/
https://patchwork.ozlabs.org/project/opensbi/patch/20231025043104.748104-2-wxjstz@126.com/

Regards,
Xiang W
> 
> Thanks,
> Anup
> 
> > 
> > Changed from v1:
> > 1. simplified by calling semihosting_puts directly.
> > 
> > ---
> >  lib/utils/serial/semihosting.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/lib/utils/serial/semihosting.c b/lib/utils/serial/semihosting.c
> > index ce65887..a27c69e 100644
> > --- a/lib/utils/serial/semihosting.c
> > +++ b/lib/utils/serial/semihosting.c
> > @@ -160,11 +160,6 @@ static long semihosting_write(long fd, const void *memp, size_t len)
> > 
> >  /* clang-format on */
> > 
> > -static void semihosting_putc(char ch)
> > -{
> > -       semihosting_trap(SYSWRITEC, &ch);
> > -}
> > -
> >  static unsigned long semihosting_puts(const char *str, unsigned long len)
> >  {
> >         char ch;
> > @@ -183,6 +178,11 @@ static unsigned long semihosting_puts(const char *str, unsigned long len)
> >         return (ret < 0) ? 0 : ret;
> >  }
> > 
> > +static void semihosting_putc(char ch)
> > +{
> > +       semihosting_puts(&ch, 1);
> > +}
> > +
> >  static int semihosting_getc(void)
> >  {
> >         char ch = 0;
> > --
> > 2.25.1
> > 
> > 
> > --
> > opensbi mailing list
> > opensbi at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/opensbi