[PATCH] lib: sbi: check A2 register in ecall_dbcn_handler.

[Anup Patel]

On Thu, Jun 22, 2023 at 11:10 PM Gianluca Guida <gianluca at rivosinc.com> wrote:
>
> Do not ignore register A2 (high bits of physical address) in the dbcn
> handler (RV64).
>
> Signed-off-by: Gianluca Guida <gianluca at rivosinc.com>

Looks good to me.

Reviewed-by: Anup Patel <anup at brainfault.org>

Applied this patch to the riscv/opensbi repo.

Thanks,
Anup

> ---
>
> The spec doesn't seem to imply that in RV64 only one paramenter will
> be used.
>
> Thanks,
> G.
>
>
>  lib/sbi/sbi_ecall_dbcn.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/lib/sbi/sbi_ecall_dbcn.c b/lib/sbi/sbi_ecall_dbcn.c
> index e0b892c..ecec027 100644
> --- a/lib/sbi/sbi_ecall_dbcn.c
> +++ b/lib/sbi/sbi_ecall_dbcn.c
> @@ -34,11 +34,14 @@ static int sbi_ecall_dbcn_handler(unsigned long extid, unsigned long funcid,
>                  * Based on above, we simply fail if the upper 32bits of
>                  * the physical address (i.e. a2 register) is non-zero on
>                  * RV32.
> +                 *
> +                 * Analogously, we fail if the upper 64bit of the
> +                 * physical address (i.e. a2 register) is non-zero on
> +                 * RV64.
>                  */
> -#if __riscv_xlen == 32
>                 if (regs->a2)
>                         return SBI_ERR_FAILED;
> -#endif
> +
>                 if (!sbi_domain_check_addr_range(sbi_domain_thishart_ptr(),
>                                         regs->a1, regs->a0, smode,
>                                         SBI_DOMAIN_READ|SBI_DOMAIN_WRITE))
> --
> 2.34.1
>
>
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi