[PATCH v6 06/12] lib: sbi: print add 'o' type

Xiang W wxjstz at 126.com
Tue Jul 4 02:55:28 PDT 2023


在 2023-07-04星期二的 10:24 +0530,Anup Patel写道:
> On Mon, Jun 12, 2023 at 1:40 PM Xiang W <wxjstz at 126.com> wrote:
> 
> No patch description ?
Will be done in next patch.

Regards,
Xiang W
> 
> > 
> > Signed-off-by: Xiang W <wxjstz at 126.com>
> > ---
> >  lib/sbi/sbi_console.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/lib/sbi/sbi_console.c b/lib/sbi/sbi_console.c
> > index a9a2ed6..047c51e 100644
> > --- a/lib/sbi/sbi_console.c
> > +++ b/lib/sbi/sbi_console.c
> > @@ -328,7 +328,8 @@ static int print(char **out, u32 *out_len, const char *format, va_list args)
> >                                              width, flags, *format);
> >                                 continue;
> >                         }
> > -                       if ((*format == 'u') || (*format == 'x') || (*format == 'X')) {
> > +                       if ((*format == 'u') || (*format == 'o')
> > +                                        || (*format == 'x') || (*format == 'X')) {
> >                                 pc += printi(out, out_len, va_arg(args, unsigned int),
> >                                              width, flags, *format);
> >                                 continue;
> > @@ -342,7 +343,7 @@ static int print(char **out, u32 *out_len, const char *format, va_list args)
> >                                 type = 'i';
> >                                 if (format[1] == 'l') {
> >                                         ++format;
> > -                                       if ((format[1] == 'u')
> > +                                       if ((format[1] == 'u') || (format[1] == 'o')
> >                                                         || (format[1] == 'd') || (format[1] == 'i')
> >                                                         || (format[1] == 'x') || (format[1] == 'X')) {
> >                                                 ++format;
> > @@ -352,7 +353,7 @@ static int print(char **out, u32 *out_len, const char *format, va_list args)
> >                                                 width, flags, type);
> >                                         continue;
> >                                 }
> > -                               if ((format[1] == 'u')
> > +                               if ((format[1] == 'u') || (format[1] == 'o')
> >                                                 || (format[1] == 'd') || (format[1] == 'i')
> >                                                 || (format[1] == 'x') || (format[1] == 'X')) {
> >                                         ++format;
> > --
> > 2.39.2
> > 
> 
> Otherwise, it looks good to me.
> 
> Reviewed-by: Anup Patel <anup at brainfault.org>
> 
> Regards,
> Anup



More information about the opensbi mailing list