[PATCH v6 02/12] lib: sbi: print not fill '0' when left-aligned

Xiang W wxjstz at 126.com
Tue Jul 4 02:54:24 PDT 2023


在 2023-07-04星期二的 09:34 +0530,Anup Patel写道:
> On Mon, Jun 12, 2023 at 1:40 PM Xiang W <wxjstz at 126.com> wrote:
> > 
> > Left alignment and padding '0' should not exist at the same time,
> > this patch is not padded with 0 when left aligned.
> 
> s/this patch is not padded with/this patch skips padding/
Will be done in next patch.

Regards,
Xiang W
> 
> > 
> > Signed-off-by: Xiang W <wxjstz at 126.com>
> > ---
> >  lib/sbi/sbi_console.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/lib/sbi/sbi_console.c b/lib/sbi/sbi_console.c
> > index 6e07663..b7d0896 100644
> > --- a/lib/sbi/sbi_console.c
> > +++ b/lib/sbi/sbi_console.c
> > @@ -288,6 +288,8 @@ static int print(char **out, u32 *out_len, const char *format, va_list args)
> >                                 if (!flags_done)
> >                                         ++format;
> >                         }
> > +                       if (flags & PAD_RIGHT)
> > +                               flags &= ~PAD_ZERO;
> >                         /* Get width */
> >                         width = 0;
> >                         for (; *format >= '0' && *format <= '9'; ++format) {
> > --
> > 2.39.2
> > 
> 
> Otherwise it looks good to me.
> 
> Reviewed-by: Anup Patel <anup at brainfault.org>
> 
> Regards,
> Anup



More information about the opensbi mailing list