[PATCH v2 4/6] lib: utils: atcsmu: Add Andes System Management Unit support
Anup Patel
anup at brainfault.org
Tue Jan 17 20:13:14 PST 2023
On Wed, Jan 18, 2023 at 7:50 AM Yu Chien Peter Lin
<peterlin at andestech.com> wrote:
>
> This patch adds atcsmu support for Andes AE350 platforms. The SMU
> provides system management capabilities, including clock, reset
> and power control based on power domain partitions.
>
> Signed-off-by: Yu Chien Peter Lin <peterlin at andestech.com>
> ---
> include/sbi_utils/sys/atcsmu.h | 63 ++++++++++++++++++++++++++++++++++
> lib/utils/sys/Kconfig | 4 +++
> lib/utils/sys/atcsmu.c | 60 ++++++++++++++++++++++++++++++++
> lib/utils/sys/objects.mk | 1 +
> platform/generic/Kconfig | 1 +
> 5 files changed, 129 insertions(+)
> create mode 100644 include/sbi_utils/sys/atcsmu.h
> create mode 100644 lib/utils/sys/atcsmu.c
>
> diff --git a/include/sbi_utils/sys/atcsmu.h b/include/sbi_utils/sys/atcsmu.h
> new file mode 100644
> index 0000000..b7e4226
> --- /dev/null
> +++ b/include/sbi_utils/sys/atcsmu.h
> @@ -0,0 +1,63 @@
> +/*
> + * SPDX-License-Identifier: BSD-3-Clause
> + *
> + * Copyright (c) 2023 Andes Technology Corporation
> + */
> +
> +#ifndef _SYS_ATCSMU_H
> +#define _SYS_ATCSMU_H
> +
> +#include <sbi_utils/sys/atcsmu.h>
> +#include <sbi/sbi_bitops.h>
> +#include <sbi/sbi_types.h>
> +#include <sbi/riscv_asm.h>
> +#include <andes/andes45.h>
Remove redundant includes from here.
> +
> +#define PCS0_WE_OFFSET 0x90
> +#define PCSm_WE_OFFSET(i) ((i + 3) * 0x20 + PCS0_WE_OFFSET)
> +
> +#define PCS0_CTL_OFFSET 0x94
> +#define PCSm_CTL_OFFSET(i) ((i + 3) * 0x20 + PCS0_CTL_OFFSET)
> +#define PCS_CTL_CMD_SHIFT 0
> +#define PCS_CTL_PARAM_SHIFT 3
> +#define SLEEP_CMD 0x3
> +#define WAKEUP_CMD (0x0 | (1 << PCS_CTL_PARAM_SHIFT))
> +#define LIGHTSLEEP_MODE 0
> +#define DEEPSLEEP_MODE 1
> +#define LIGHT_SLEEP_CMD (SLEEP_CMD | (LIGHTSLEEP_MODE << PCS_CTL_PARAM_SHIFT))
> +#define DEEP_SLEEP_CMD (SLEEP_CMD | (DEEPSLEEP_MODE << PCS_CTL_PARAM_SHIFT))
> +
> +#define PCS0_CFG_OFFSET 0x80
> +#define PCSm_CFG_OFFSET(i) ((i + 3) * 0x20 + PCS0_CFG_OFFSET)
> +#define PCS_CFG_LIGHT_SLEEP_SHIFT 2
> +#define PCS_CFG_LIGHT_SLEEP (1 << PCS_CFG_LIGHT_SLEEP_SHIFT)
> +#define PCS_CFG_DEEP_SLEEP_SHIFT 3
> +#define PCS_CFG_DEEP_SLEEP (1 << PCS_CFG_DEEP_SLEEP_SHIFT)
> +#define RESET_VEC_LO_OFFSET 0x50
> +#define RESET_VEC_HI_OFFSET 0x60
> +#define RESET_VEC_8CORE_OFFSET 0x1a0
> +#define HARTn_RESET_VEC_LO(n) \
> + (RESET_VEC_LO_OFFSET + \
> + ((n) < 4 ? 0 : RESET_VEC_8CORE_OFFSET) + ((n) * 0x4))
> +#define HARTn_RESET_VEC_HI(n) \
> + (RESET_VEC_HI_OFFSET + \
> + ((n) < 4 ? 0 : RESET_VEC_8CORE_OFFSET) + ((n) * 0x4))
> +#define PCS_MAX_NR 8
> +#define FLASH_BASE 0x80000000ULL
> +
> +struct smu_data {
> + unsigned long addr;
> +};
> +
> +static __always_inline bool is_andes25(void)
> +{
> + ulong marchid = csr_read(CSR_MARCHID);
> + return !!(EXTRACT_FIELD(marchid, CSR_MARCHID_MICROID) == 0xa25);
> +}
The is_andes25() is not used anywhere in atcsmu.h and atchsmu.c
so better to keep this in andes platform code for now.
> +
> +void smu_set_wakeup_events(u32 events, u32 hartid);
> +bool smu_support_sleep_mode(u32 sleep_mode, u32 hartid);
> +void smu_set_command(u32 pcs_ctl, u32 hartid);
> +void smu_set_reset_vector(ulong wakeup_addr, u32 hartid);
> +
> +#endif /* _SYS_ATCSMU_H */
> diff --git a/lib/utils/sys/Kconfig b/lib/utils/sys/Kconfig
> index ee85b1a..76190f8 100644
> --- a/lib/utils/sys/Kconfig
> +++ b/lib/utils/sys/Kconfig
> @@ -2,6 +2,10 @@
>
> menu "System Device Support"
>
> +config SYS_ATCSMU
> + bool "Andes System Management Unit (SMU) support"
> + default n
> +
> config SYS_HTIF
> bool "Host transfere interface (HTIF) support"
> default n
> diff --git a/lib/utils/sys/atcsmu.c b/lib/utils/sys/atcsmu.c
> new file mode 100644
> index 0000000..b38ec70
> --- /dev/null
> +++ b/lib/utils/sys/atcsmu.c
> @@ -0,0 +1,60 @@
> +/*
> + * SPDX-License-Identifier: BSD-3-Clause
> + *
> + * Copyright (c) 2023 Andes Technology Corporation
> + */
> +
> +#include <sbi_utils/sys/atcsmu.h>
> +#include <sbi/riscv_io.h>
> +#include <sbi/sbi_bitops.h>
> +#include <sbi/sbi_console.h>
> +#include <sbi/sbi_error.h>
> +#include <andes/andes45.h>
> +
> +extern struct smu_data smu;
If atcsmu is enabled from a platform not defining "smu" variable
then it would result in linker error.
I suggest all functions in atcsmu.c should have "struct smu_data *smu"
as a parameter and calling platform code will instantiate struct smu_data.
Regards,
Anup
> +
> +void smu_set_wakeup_events(u32 events, u32 hartid)
> +{
> + writel(events, (void *)(smu.addr + PCSm_WE_OFFSET(hartid)));
> +}
> +
> +bool smu_support_sleep_mode(u32 sleep_mode, u32 hartid)
> +{
> + u32 pcs_cfg;
> +
> + pcs_cfg = readl((void *)(smu.addr + PCSm_CFG_OFFSET(hartid)));
> +
> + switch (sleep_mode) {
> + case LIGHTSLEEP_MODE:
> + if (EXTRACT_FIELD(pcs_cfg, PCS_CFG_LIGHT_SLEEP) == 0) {
> + sbi_printf(
> + "SMU: hart%d (PCS%d) does not support light sleep mode\n",
> + hartid, hartid + 3);
> + return false;
> + }
> + break;
> + case DEEPSLEEP_MODE:
> + if (EXTRACT_FIELD(pcs_cfg, PCS_CFG_DEEP_SLEEP) == 0) {
> + sbi_printf(
> + "SMU: hart%d (PCS%d) does not support deep sleep mode\n",
> + hartid, hartid + 3);
> + return false;
> + }
> + break;
> + }
> +
> + return true;
> +}
> +
> +void smu_set_command(u32 pcs_ctl, u32 hartid)
> +{
> + writel(pcs_ctl, (void *)(smu.addr + PCSm_CTL_OFFSET(hartid)));
> +}
> +
> +void smu_set_reset_vector(ulong wakeup_addr, u32 hartid)
> +{
> + writel(wakeup_addr,
> + (void *)(smu.addr + HARTn_RESET_VEC_LO(hartid)));
> + writel((u64)wakeup_addr >> 32,
> + (void *)(smu.addr + HARTn_RESET_VEC_HI(hartid)));
> +}
> diff --git a/lib/utils/sys/objects.mk b/lib/utils/sys/objects.mk
> index 9f67aee..03d6740 100644
> --- a/lib/utils/sys/objects.mk
> +++ b/lib/utils/sys/objects.mk
> @@ -9,3 +9,4 @@
>
> libsbiutils-objs-$(CONFIG_SYS_HTIF) += sys/htif.o
> libsbiutils-objs-$(CONFIG_SYS_SIFIVE_TEST) += sys/sifive_test.o
> +libsbiutils-objs-$(CONFIG_SYS_ATCSMU) += sys/atcsmu.o
> diff --git a/platform/generic/Kconfig b/platform/generic/Kconfig
> index 47c10e5..c7f198a 100644
> --- a/platform/generic/Kconfig
> +++ b/platform/generic/Kconfig
> @@ -30,6 +30,7 @@ config PLATFORM_ALLWINNER_D1
>
> config PLATFORM_ANDES_AE350
> bool "Andes AE350 support"
> + select SYS_ATCSMU
> default n
>
> config PLATFORM_RENESAS_RZFIVE
> --
> 2.34.1
>
>
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi
More information about the opensbi
mailing list