[RFC PATCH 04/11] lib: sbi_hsm: Move misplaced comment

[Anup Patel]

On Fri, Jan 6, 2023 at 4:52 PM Andrew Jones <ajones at ventanamicro.com> wrote:
>
> While non-retentive suspend is not allowed for M-mode, the comment
> at the top of sbi_hsm_hart_suspend() implied suspend wasn't allowed
> for M-mode at all. Move the comment above the mode check which is
> inside a suspend type is non-retentive check.
>
> Signed-off-by: Andrew Jones <ajones at ventanamicro.com>

Looks good to me.

Reviewed-by: Anup Patel <anup at brainfault.org>

Regards,
Anup

> ---
>  lib/sbi/sbi_hsm.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/sbi/sbi_hsm.c b/lib/sbi/sbi_hsm.c
> index 3635f968e020..cce4b07bbb36 100644
> --- a/lib/sbi/sbi_hsm.c
> +++ b/lib/sbi/sbi_hsm.c
> @@ -399,8 +399,6 @@ int sbi_hsm_hart_suspend(struct sbi_scratch *scratch, u32 suspend_type,
>         struct sbi_hsm_data *hdata = sbi_scratch_offset_ptr(scratch,
>                                                             hart_data_offset);
>
> -       /* For now, we only allow suspend from S-mode or U-mode. */
> -
>         /* Sanity check on domain assigned to current HART */
>         if (!dom)
>                 return SBI_EFAIL;
> @@ -415,6 +413,10 @@ int sbi_hsm_hart_suspend(struct sbi_scratch *scratch, u32 suspend_type,
>
>         /* Additional sanity check for non-retentive suspend */
>         if (suspend_type & SBI_HSM_SUSP_NON_RET_BIT) {
> +               /*
> +                * For now, we only allow non-retentive suspend from
> +                * S-mode or U-mode.
> +                */
>                 if (rmode != PRV_S && rmode != PRV_U)
>                         return SBI_EFAIL;
>                 if (dom && !sbi_domain_check_addr(dom, raddr, rmode,
> --
> 2.39.0
>
>
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi