[PATCH 5/6] lib: reset/fdt_reset_atcwdt200: use defined macros in atcsmu.h

Yu-Chien Peter Lin peterlin at andestech.com
Mon Jan 16 12:17:16 PST 2023


Hi Anup,

On Mon, Jan 16, 2023 at 02:45:51PM +0530, Anup Patel wrote:
> On Wed, Jan 4, 2023 at 12:02 PM Yu Chien Peter Lin
> <peterlin at andestech.com> wrote:
> >
> > Reuse the smu related macros defined in atcsmu.h.
> >
> > Signed-off-by: Yu Chien Peter Lin <peterlin at andestech.com>
> > ---
> >  lib/utils/reset/fdt_reset_atcwdt200.c | 12 ++++--------
> >  1 file changed, 4 insertions(+), 8 deletions(-)
> >
> > diff --git a/lib/utils/reset/fdt_reset_atcwdt200.c b/lib/utils/reset/fdt_reset_atcwdt200.c
> > index 91acc9f..a6e6834 100644
> > --- a/lib/utils/reset/fdt_reset_atcwdt200.c
> > +++ b/lib/utils/reset/fdt_reset_atcwdt200.c
> > @@ -17,6 +17,8 @@
> >  #include <sbi_utils/fdt/fdt_helper.h>
> >  #include <sbi_utils/reset/fdt_reset.h>
> >
> > +#include <andes/atcsmu.h>
> > +
> 
> This can result in compile error because andes/atcsmu.h is
> part of platform code.
> 
> I suggest that andes/atcsmu.h should be in a common location
> include/sbi_utils/sys/ which is meant for common system devices.
>
> Regards,
> Anup

OK, will fix.

Thanks,
Peter Lin



More information about the opensbi mailing list