[PATCH 1/3] lib: sbi/sbi_domain: cosmetic style fixes

Anup Patel anup at brainfault.org
Mon Feb 27 05:54:13 PST 2023


On Fri, Feb 24, 2023 at 9:58 AM Bin Meng <bmeng at tinylab.org> wrote:
>
> Minor updates to the comments for language and style fixes.
>
> Signed-off-by: Bin Meng <bmeng at tinylab.org>

Looks good to me.

Reviewed-by: Anup Patel <anup at brainfault.org>

Applied this patch to the riscv/opensbi repo.

Thanks,
Anup

> ---
>
>  lib/sbi/sbi_domain.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c
> index dc825b0..d2f58a2 100644
> --- a/lib/sbi/sbi_domain.c
> +++ b/lib/sbi/sbi_domain.c
> @@ -337,7 +337,7 @@ static int sanitize_domain(const struct sbi_platform *plat,
>         /*
>          * Check next mode
>          *
> -        * We only allow next mode to be S-mode or U-mode.so that we can
> +        * We only allow next mode to be S-mode or U-mode, so that we can
>          * protect M-mode context and enforce checks on memory accesses.
>          */
>         if (dom->next_mode != PRV_S &&
> @@ -347,7 +347,7 @@ static int sanitize_domain(const struct sbi_platform *plat,
>                 return SBI_EINVAL;
>         }
>
> -       /* Check next address and next mode*/
> +       /* Check next address and next mode */
>         if (!sbi_domain_check_addr(dom, dom->next_addr, dom->next_mode,
>                                    SBI_DOMAIN_EXECUTE)) {
>                 sbi_printf("%s: %s next booting stage address 0x%lx can't "
> --
> 2.25.1
>



More information about the opensbi mailing list