[PATCH] docs/platform: thead-c9xx: Improve the documentation

Guo Ren guoren at kernel.org
Fri Aug 11 17:48:56 PDT 2023


On Sat, Aug 12, 2023 at 8:16 AM Conor Dooley <conor at kernel.org> wrote:
>
> On Sat, Aug 12, 2023 at 08:07:50AM +0800, Guo Ren wrote:
> > On Sat, Aug 12, 2023 at 1:57 AM Conor Dooley <conor at kernel.org> wrote:
> > >
> > > On Fri, Aug 11, 2023 at 12:33:32AM +0800, Jisheng Zhang wrote:
> > > > On Tue, Aug 08, 2023 at 09:29:58AM -0400, guoren at kernel.org wrote:
> > > > > From: Guo Ren <guoren at linux.alibaba.com>
> > >
> > > > > +T-HEAD Fdt Reset Driver Introduction
> > > > > +------------------------------------
> > > > > +
> > > > > +Every T-HEAD CPU provides a reset control signal and reset address signals.
> > > > > + - Reset address signal determines CPU where to start up.
> > > > > + - Reset control signal releases CPU from reset state and begins to execute
> > > > > +   at reset address.
> > > > > +
> > > > > +Many vendors would gather these signals into SoC control registers. These
> > > > > +register designs are similar but with different base addresses and bits
> > > > > +definitions. We only provide standard opensbi, Linux binaries, and jtag gdbinit
> > > > > +script to simplify Linux booting at the FPGA stage. The fdt reset driver helps
> > > > > +users bring up their SMP system quickly with the below settings:
> > > >
> > > > +DT maintainers and DT list.
> > > >
> > > > I can submit a dt-binding for this if DT maintainers agree with below
> > > > properties. Could you please help review?
> > >
> > > I already reviewed this once & nothing has improved.
> > > In fact, things have gotten worse IMO with this "using-csr-reset" that I
> > > don't think existed in the original iteration that I saw.
> > > I did see things getting better with the use of standard stuff like
> > > "reg" in our earlier discussion which I don't see here.
>
> > It's not a patch to improve the implementation and we don't make a
> > deal in that discussion. This patch improves the document because the
> > previous doc didn't describe the whole thing about the
> > thead,reset-sample driver.
>
> That's all well and good, but there's still no point in Rob, Krzysztof
> or I reviewing it, which is what was being requested in the email I was
> replying to.
We aim not to deliver any custom software binaries to our CPU
customers. Only generic opensbi & Linux images are all enough at the
prototype stage.

>
> > > What is the point in carrying out any further review if things will be
> > > flat out ignored?



-- 
Best Regards
 Guo Ren



More information about the opensbi mailing list