[PATCH 1/2] firmware: Optimize loading relocation type

Xiang W wxjstz at 126.com
Tue Apr 11 21:39:06 PDT 2023


在 2023-04-04星期二的 12:46 +0800,Bin Meng写道:
> 't5' already contains relocation type so don't bother reloading it.
> 
> Signed-off-by: Bin Meng <bmeng at tinylab.org>
LGTM

Reviewed-by: Xiang W <wxjstz at 126.com>
> ---
> 
>  firmware/fw_base.S | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/firmware/fw_base.S b/firmware/fw_base.S
> index ceef44f..e30aca6 100644
> --- a/firmware/fw_base.S
> +++ b/firmware/fw_base.S
> @@ -95,7 +95,6 @@ _try_lottery:
>         lla     t4, __dyn_sym_start
>  
>  4:
> -       REG_L   t5, -(REGBYTES*2)(t0)   /* t5 <-- relocation info:type */
>         srli    t6, t5, SYM_INDEX       /* t6 <--- sym table index */
>         andi    t5, t5, 0xFF            /* t5 <--- relocation type */
>         li      t3, RELOC_TYPE
> -- 
> 2.25.1
> 
> 



More information about the opensbi mailing list