[PATCH v4 08/14] lib: utils/timer: Add Andes fdt timer support

Anup Patel anup at brainfault.org
Thu Oct 20 22:11:56 PDT 2022


On Mon, Oct 17, 2022 at 12:45 AM Samuel Holland <samuel at sholland.org> wrote:
>
> On 10/13/22 19:32, Yu Chien Peter Lin wrote:
> > Since we can get the PLMT base address and timer frequency from
> > device tree, move plmt timer device to fdt timer framework.
> >
> > dts example (Quad-core AX45MP):
> >
> >   cpus {
> >       ...
> >       timebase-frequency = <0x3938700>;
> >       ...
> >   }
> >   soc {
> >       ...
> >       plmt0 at e6000000 {
> >           compatible = "andestech,plmt0";
> >           reg = <0x00 0xe6000000 0x00 0x100000>;
> >           interrupts-extended = <&cpu0_intc 0x07
> >                                  &cpu1_intc 0x07
> >                                  &cpu2_intc 0x07
> >                                  &cpu3_intc 0x07>;
> >       };
> >       ...
> >   }
>
> Where is the binding for this compatible string? I do not see anything
> either upstream or downstream:
>
> https://lore.kernel.org/linux-devicetree/?q=andestech%2Cplmt0
> https://github.com/andestech/linux/commits/RISCV-Linux-5.4-ast-v5_1_0-branch/Documentation/devicetree/bindings
>
> We really shouldn't be accepting any devicetree compatible unless a YAML
> binding for it exists, ideally one acked by the DT schema maintainers.
>

Ideally, we should only accept patches for which DT bindings
have been accepted in kernel but at the moment we are not
strict about this as long as:
1) It does not affect other platforms
2) The platform/SoC vendor are willing to keep things up-to-date
    whenever DT bindings are merged in kernel

I am still not sure about from which OpenSBI release we should
change our patch acceptance policy and mandate DT bindings to
be present in the kernel.

Regards,
Anup



More information about the opensbi mailing list