[PATCH 1/1] firmware: Minor optimization for relocate

Dongdong Zhang zhangdongdong at eswincomputing.com
Tue Nov 29 01:10:31 PST 2022


Hi, Bin

Thank you for your review, and I will pay attention to the style of the commit message next time.

> -----原始邮件-----发件人:"Bin Meng" <bmeng.cn at gmail.com>发送时间:2022-11-29 15:51:33 (星期二)收件人:"Dongdong Zhang" <zhangdongdong at eswincomputing.com>抄送:opensbi at lists.infradead.org主题:Re: [PATCH 1/1] firmware: Minor optimization for relocate
> 
> On Tue, Nov 29, 2022 at 11:57 AM Dongdong Zhang
> <zhangdongdong at eswincomputing.com> wrote:
> >
> > The t3 register stores the address of _load_end. If relocation is not required, it is unnecessary to calculate the address of _load_end.
> 
> nits: commit messages should be written like about 70 characters per line.
> 
> >
> > This can reduce the operation time of two instructions.
> >
> > Signed-off-by: Dongdong Zhang <zhangdongdong at eswincomputing.com>
> > ---
> >  firmware/fw_base.S | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> 
> Reviewed-by: Bin Meng <bmeng at tinylab.org>


More information about the opensbi mailing list