[PATCH 1/4] platform: generic/andes: Enable generic platform support for AE350

Yu-Chien Peter Lin peterlin at andestech.com
Mon Nov 28 12:28:42 PST 2022


On Mon, Nov 28, 2022 at 10:34:06AM +0000, Lad, Prabhakar wrote:
> Hi Lin-san,
> 
> On Mon, Nov 28, 2022 at 8:32 AM Yu Chien Peter Lin
> <peterlin at andestech.com> wrote:
> >
> > We move andes directory to platform/generic since the necessary fdt
> > drivers are available, the users can enable the console, timer, ipi,
> > irqchip and reset devices by adding device tree nodes stated in the
> > docs/platform/andes-ae350.md.
> >
> > Signed-off-by: Yu Chien Peter Lin <peterlin at andestech.com>
> > ---
> > Although generic/platform.c has been able to boot the system
> > on AE350, we will add HSM device for it soon so let's keep
> > ae350.c as a placeholder.
> > ---
> >  platform/andes/ae350/Kconfig           |  34 -----
> >  platform/andes/ae350/cache.c           |  89 -------------
> >  platform/andes/ae350/cache.h           |  17 ---
> >  platform/andes/ae350/configs/defconfig |   0
> >  platform/andes/ae350/objects.mk        |  40 ------
> >  platform/andes/ae350/platform.c        | 169 -------------------------
> >  platform/andes/ae350/platform.h        | 109 ----------------
> >  platform/generic/Kconfig               |   4 +
> >  platform/generic/andes/ae350.c         |  21 +++
> >  platform/generic/andes/objects.mk      |   6 +
> >  platform/generic/configs/defconfig     |   4 +
> >  11 files changed, 35 insertions(+), 458 deletions(-)
> >  delete mode 100644 platform/andes/ae350/Kconfig
> >  delete mode 100644 platform/andes/ae350/cache.c
> >  delete mode 100644 platform/andes/ae350/cache.h
> You have got rid of cache functions and also the vendor specific EXT
> handler, wouldn't that break things?

Hi Prabhakar,

I want to take this opportunity to drop unnecessary functions, most of
the andes SBI calls were experimental/debugging features in kernel that
won't affact the boot flow.

You can still keep them in generic/renesas/rzfive.c. The renesas vendor
SBI call fid does not need to be the same as ours.

As for common Andes CSR which you separated into andes/ae350/common-platform.h
can be moved to generic/include/andes45.h.

Best regards,
Peter Lin

> Cheers,
> Prabhakar



More information about the opensbi mailing list