[PATCH 5/5] lib: simplify fdt_translate_address()

Xiang W wxjstz at 126.com
Sat Nov 26 04:55:07 PST 2022


在 2022-11-25星期五的 15:08 +0100,Heinrich Schuchardt写道:
> Don't assign a value to offset which is never used.
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
Look good to me

Reviewed-by: Xiang W <wxjstz at 126.com>
> ---
>  lib/utils/fdt/fdt_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/utils/fdt/fdt_helper.c b/lib/utils/fdt/fdt_helper.c
> index da96282..b8d0eea 100644
> --- a/lib/utils/fdt/fdt_helper.c
> +++ b/lib/utils/fdt/fdt_helper.c
> @@ -124,7 +124,7 @@ static int fdt_translate_address(void *fdt, uint64_t reg, int parent,
>         int i, rlen;
>         int cell_addr, cell_size;
>         const fdt32_t *ranges;
> -       uint64_t offset = 0, caddr = 0, paddr = 0, rsize = 0;
> +       uint64_t offset, caddr = 0, paddr = 0, rsize = 0;
>  
>         cell_addr = fdt_address_cells(fdt, parent);
>         if (cell_addr < 1)
> -- 
> 2.37.2
> 
> 





More information about the opensbi mailing list