[PATCH] Makefile: bugfix for handling platform paths
Xiang W
wxjstz at 126.com
Tue Nov 22 05:42:38 PST 2022
在 2022-11-22星期二的 12:28 +0200,Alejandro Cabrera Aldaya写道:
> If the path where this repo is located contains the platform name on it,
> the original Makefile replaced its occurrences from the path making it an invalid path.
> This commit prevents this behavior replacing only the last part of the path as intended.
>
> Signed-off-by: Alejandro Cabrera Aldaya <aldaya at gmail.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 8db6eab..32d4c48 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -47,7 +47,7 @@ ifdef PLATFORM_DIR
> platform_parent_dir=$(platform_dir_path)
> else
> PLATFORM=$(shell basename $(platform_dir_path))
> - platform_parent_dir=$(subst $(PLATFORM),,$(platform_dir_path))
> + platform_parent_dir=$(shell dirname $(shell realpath $(platform_dir_path)))
>
Looks good, could simplify it a bit.
platform_parent_dir=$(shell realpath ${platform_dir_path}/..)
Reviewed-by: Xiang W <wxjstz at 126.com>
> endif
> else
> platform_parent_dir=$(src_dir)/platform
> --
> 2.34.1
>
>
More information about the opensbi
mailing list