[PATCH] lib: utils/serial: Fix semihosting compile error using LLVM

[Xiang W]

在 2022-11-08星期二的 10:02 +0100，Andreas Schwab写道：
> On Nov 08 2022, Anup Patel wrote:
> 
> > diff --git a/lib/utils/serial/semihosting.c b/lib/utils/serial/semihosting.c
> > index 5012fa1..72bbbb3 100644
> > --- a/lib/utils/serial/semihosting.c
> > +++ b/lib/utils/serial/semihosting.c
> > @@ -155,7 +155,7 @@ static int semihosting_getc(void)
> >  
> >         if (semihosting_infd < 0)  {
> >                 ch = semihosting_trap(SYSREADC, NULL);
> 
> This is using the wrong variable to record the return value of
> semihosting_trap (which is of type long, not char).
> 
> > -               ret = ch > -1 ? ch : -1;
> > +               ret = ((int)ch > -1) ? ch : -1;
> 
> I think this line can be removed, and the return value of
> semihosting_trap can be returned directly.

This line is used to handle error codes, semihosting_trap may
have multiple return values less than 0, but console_getc can
only return -1.

Suggest:
		ret = semihosting_trap(SYSREADC, NULL);
		ret = ret < 0 ? -1 : ret;

Regards,
Xiang W
> 
> -- 
> Andreas Schwab, SUSE Labs, schwab at suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."
>