[PATCH V2] include: Add check for offset of sbi_platform
Xiang W
wxjstz at 126.com
Sun Mar 27 01:36:05 PDT 2022
Add static detection to prevent the modification of struct sbi_platform
from forgetting the modification of SBI_PLATFORM_xxx_OFFSET
Signed-off-by: Xiang W <wxjstz at 126.com>
---
V2 change:
* reword commit message
* change comment style
include/sbi/sbi_platform.h | 50 ++++++++++++++++++++++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git a/include/sbi/sbi_platform.h b/include/sbi/sbi_platform.h
index 0b5ae4b..2c777ac 100644
--- a/include/sbi/sbi_platform.h
+++ b/include/sbi/sbi_platform.h
@@ -175,6 +175,56 @@ struct sbi_platform {
const u32 *hart_index2id;
};
+/**
+ * Prevent modification of struct sbi_platform from affecting
+ * SBI_PLATFORM_xxx_OFFSET
+ */
+_Static_assert(
+ offsetof(struct sbi_platform, opensbi_version)
+ == SBI_PLATFORM_OPENSBI_VERSION_OFFSET,
+ "struct sbi_platform definition has changed, please redefine "
+ "SBI_PLATFORM_OPENSBI_VERSION_OFFSET");
+_Static_assert(
+ offsetof(struct sbi_platform, platform_version)
+ == SBI_PLATFORM_VERSION_OFFSET,
+ "struct sbi_platform definition has changed, please redefine "
+ "SBI_PLATFORM_VERSION_OFFSET");
+_Static_assert(
+ offsetof(struct sbi_platform, name)
+ == SBI_PLATFORM_NAME_OFFSET,
+ "struct sbi_platform definition has changed, please redefine "
+ "SBI_PLATFORM_NAME_OFFSET");
+_Static_assert(
+ offsetof(struct sbi_platform, features)
+ == SBI_PLATFORM_FEATURES_OFFSET,
+ "struct sbi_platform definition has changed, please redefine "
+ "SBI_PLATFORM_FEATURES_OFFSET");
+_Static_assert(
+ offsetof(struct sbi_platform, hart_count)
+ == SBI_PLATFORM_HART_COUNT_OFFSET,
+ "struct sbi_platform definition has changed, please redefine "
+ "SBI_PLATFORM_HART_COUNT_OFFSET");
+_Static_assert(
+ offsetof(struct sbi_platform, hart_stack_size)
+ == SBI_PLATFORM_HART_STACK_SIZE_OFFSET,
+ "struct sbi_platform definition has changed, please redefine "
+ "SBI_PLATFORM_HART_STACK_SIZE_OFFSET");
+_Static_assert(
+ offsetof(struct sbi_platform, platform_ops_addr)
+ == SBI_PLATFORM_OPS_OFFSET,
+ "struct sbi_platform definition has changed, please redefine "
+ "SBI_PLATFORM_OPS_OFFSET");
+_Static_assert(
+ offsetof(struct sbi_platform, firmware_context)
+ == SBI_PLATFORM_FIRMWARE_CONTEXT_OFFSET,
+ "struct sbi_platform definition has changed, please redefine "
+ "SBI_PLATFORM_FIRMWARE_CONTEXT_OFFSET");
+_Static_assert(
+ offsetof(struct sbi_platform, hart_index2id)
+ == SBI_PLATFORM_HART_INDEX2ID_OFFSET,
+ "struct sbi_platform definition has changed, please redefine "
+ "SBI_PLATFORM_HART_INDEX2ID_OFFSET");
+
/** Get pointer to sbi_platform for sbi_scratch pointer */
#define sbi_platform_ptr(__s) \
((const struct sbi_platform *)((__s)->platform_addr))
--
2.30.2
More information about the opensbi
mailing list